Skip to content

Commit fad29b1

Browse files
committed
address comments
1 parent fc80650 commit fad29b1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

docs/pages/product/configuration/data-sources/snowflake.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ Ensure the AWS credentials are correctly configured in IAM to allow reads and
137137
writes to the export bucket in S3. You can authenticate using:
138138

139139
- **IAM user credentials** - Explicit AWS access keys and secrets
140-
- **Storage integration** - Snowflake-managed AWS integration (may still require credentials for Cube Store)
140+
- **Storage integration** - Snowflake-managed AWS integration (may still require credentials for exported file processing)
141141
- **IAM roles** - Use execution environment roles (IRSA, instance profiles) for both Snowflake and Cube Store
142142

143143
</InfoBox>

packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import { formatToTimeZone } from 'date-fns-timezone';
2424
import fs from 'fs/promises';
2525
import crypto from 'crypto';
2626
import { HydrationMap, HydrationStream } from './HydrationStream';
27+
import { S3ClientConfig } from '@aws-sdk/client-s3';
2728

2829
const SUPPORTED_BUCKET_TYPES = ['s3', 'gcs', 'azure'];
2930

@@ -793,7 +794,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
793794
const { bucketName, path } = this.parseBucketUrl(this.config.exportBucket!.bucketName);
794795
const exportPrefix = path ? `${path}/${tableName}` : tableName;
795796

796-
const s3Config: any = { region };
797+
const s3Config: S3ClientConfig = { region };
797798
if (keyId && secretKey) {
798799
// If access key and secret are provided, use them as credentials
799800
// Otherwise, let the SDK use the default credential chain (IRSA, instance profile, etc.)

0 commit comments

Comments
 (0)