Skip to content

Commit fcd7d54

Browse files
committed
refactor(cubesql): Remove unused plan argument from CubeScanWrapperNode::generate_column_expr
1 parent 3cf8e3f commit fcd7d54

File tree

1 file changed

+0
-8
lines changed
  • rust/cubesql/cubesql/src/compile/engine/df

1 file changed

+0
-8
lines changed

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,7 +1126,6 @@ impl CubeScanWrapperNode {
11261126
})?
11271127
.clone();
11281128
let (projection, sql) = Self::generate_column_expr(
1129-
plan.clone(),
11301129
schema.clone(),
11311130
projection_expr.clone(),
11321131
sql,
@@ -1140,7 +1139,6 @@ impl CubeScanWrapperNode {
11401139
.await?;
11411140
let flat_group_expr = extract_exprlist_from_groupping_set(&group_expr);
11421141
let (group_by, sql) = Self::generate_column_expr(
1143-
plan.clone(),
11441142
schema.clone(),
11451143
flat_group_expr.clone(),
11461144
sql,
@@ -1154,7 +1152,6 @@ impl CubeScanWrapperNode {
11541152
.await?;
11551153
let group_descs = extract_group_type_from_groupping_set(&group_expr)?;
11561154
let (aggregate, sql) = Self::generate_column_expr(
1157-
plan.clone(),
11581155
schema.clone(),
11591156
aggr_expr.clone(),
11601157
sql,
@@ -1168,7 +1165,6 @@ impl CubeScanWrapperNode {
11681165
.await?;
11691166

11701167
let (filter, sql) = Self::generate_column_expr(
1171-
plan.clone(),
11721168
schema.clone(),
11731169
filter_expr.clone(),
11741170
sql,
@@ -1182,7 +1178,6 @@ impl CubeScanWrapperNode {
11821178
.await?;
11831179

11841180
let (window, sql) = Self::generate_column_expr(
1185-
plan.clone(),
11861181
schema.clone(),
11871182
window_expr.clone(),
11881183
sql,
@@ -1196,7 +1191,6 @@ impl CubeScanWrapperNode {
11961191
.await?;
11971192

11981193
let (order, mut sql) = Self::generate_column_expr(
1199-
plan.clone(),
12001194
schema.clone(),
12011195
order_expr.clone(),
12021196
sql,
@@ -1224,7 +1218,6 @@ impl CubeScanWrapperNode {
12241218
{
12251219
// Need to call generate_column_expr to apply column_remapping
12261220
let (join_condition, new_sql) = Self::generate_column_expr(
1227-
plan.clone(),
12281221
schema.clone(),
12291222
[condition.clone()],
12301223
sql,
@@ -1511,7 +1504,6 @@ impl CubeScanWrapperNode {
15111504
}
15121505

15131506
async fn generate_column_expr(
1514-
_plan: Arc<Self>,
15151507
schema: DFSchemaRef,
15161508
exprs: impl IntoIterator<Item = Expr>,
15171509
mut sql: SqlQuery,

0 commit comments

Comments
 (0)