Elasticsearch - Result formatting differences

[dylman79]

A recent change to conform with elaastic.co result formatting (to cope with json result) is not compatible with open distro/aws es sql result formatting. In open distro case, json formatting is more like the standard es result format whereas json format in elastic.co is more like a jdbc format.

This is the offending code.
https://github.com/cube-js/cube.js/blob/c1e25d7184c5ed63ba083da1cd9cf0f2111b8011/packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js#L86

We perhaps need to split the driver in some way - either entirely or certainly the query and driver.

I am happy to look at PR for this

To Reproduce
setting result format to json while using awses/open distro - json result formatting results in an exception

Expected behavior
Both open distro and elastic.co should be supported either via single driver or multiple

Version:
latest

[github-actions]

If you are interested in working on this issue, please leave a comment below and we will be happy to assign the issue to you.
If this is the first time you are contributing a Pull Request to Cube.js, please check our contribution guidelines.
You can also post any questions while contributing in the #contributors channel in the Cube.js Slack.

[hassankhan]

Hi @dylman79, I think this might be a duplicate of #2370. Would you mind trying out @rongfengliang's OpenDistro driver (from this comment) and seeing if it works? Thanks in advance 😀

[dylman79]

@hassankhan It is similar in that the issue there is the lack of functions in open distro in comparison to elastic.co. The driver looks like an exact copy of the driver as it was before the latest changes with a minor tweak to the result format and a change to the dialectClass. I think the approach should perhaps to keep the elastic search drivers together (at least for now), but separate the query, and separate the result processing. As I said - I am more than happy to take a look at doing this and raising a PR - I propose we combine the open distro driver on the external repo into the existing one in cubejs - as was the original intent I believe