From 5c465f7aac15df83ddf6c96b83ab0f8c5a9230bf Mon Sep 17 00:00:00 2001 From: Pavel Tiunov Date: Wed, 5 Nov 2025 09:58:44 -0800 Subject: [PATCH 1/2] fix: Simplify external refresh condition so when pre-aggregation builder is set so it's never an external refresh instance --- packages/cubejs-server-core/src/core/OptsHandler.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/cubejs-server-core/src/core/OptsHandler.ts b/packages/cubejs-server-core/src/core/OptsHandler.ts index 5d82786375e67..015a59f9b647f 100644 --- a/packages/cubejs-server-core/src/core/OptsHandler.ts +++ b/packages/cubejs-server-core/src/core/OptsHandler.ts @@ -686,10 +686,7 @@ export class OptsHandler { clone.preAggregationsOptions.externalRefresh = clone.preAggregationsOptions.externalRefresh !== undefined ? clone.preAggregationsOptions.externalRefresh - : ( - !this.isPreAggsBuilder() || - clone.rollupOnlyMode && !this.configuredForScheduledRefresh() - ); + : !this.isPreAggsBuilder(); clone.preAggregationsOptions.maxPartitions = clone.preAggregationsOptions.maxPartitions !== undefined From 0dea2a36a525327e74552f0cf161aa659b369431 Mon Sep 17 00:00:00 2001 From: Pavel Tiunov Date: Wed, 5 Nov 2025 13:43:39 -0800 Subject: [PATCH 2/2] Fix tests should be in production mode --- packages/cubejs-server-core/test/unit/index.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/cubejs-server-core/test/unit/index.test.ts b/packages/cubejs-server-core/test/unit/index.test.ts index 5e96e6566480e..47784fc4a2038 100644 --- a/packages/cubejs-server-core/test/unit/index.test.ts +++ b/packages/cubejs-server-core/test/unit/index.test.ts @@ -665,6 +665,8 @@ describe('index.test', () => { }); test(testName || `scheduledRefreshTimer option setRefreshWorker: ${paramsToName})}`, async () => { + process.env.NODE_ENV = 'production'; + if (setRefreshWorker !== undefined) { process.env.CUBEJS_REFRESH_WORKER = setRefreshWorker.toString(); }