Skip to content

fix(trino-driver, presto-driver): Qualify information schema queries with a catalog name #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(trino-driver, presto-driver): Qualify information schema queries with a catalog name #10158

wants to merge 1 commit into from

Conversation

@igorlukanin
Copy link
Member

@igorlukanin igorlukanin commented Nov 19, 2025

No description provided.

@igorlukanin igorlukanin requested a review from a team as a code owner November 19, 2025 16:41
@github-actions github-actions bot added driver:prestodb Issues relating to the PrestoDB driver javascript Pull requests that update Javascript code data source driver labels Nov 19, 2025
@igorlukanin igorlukanin changed the title fix(trino-driver, presto-driver): Qualify information schema queries … fix(trino-driver, presto-driver): Qualify information schema queries with a catalog name Nov 19, 2025
KSDaemon
KSDaemon approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, these are kind of the same queries as in BaseQuery, just prefixed with the catalog name, right?

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.69%. Comparing base (d6b4c21) to head (e025469).

Files with missing lines Patch % Lines
...ackages/cubejs-prestodb-driver/src/PrestoDriver.ts 9.09% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10158      +/-   ##
==========================================
- Coverage   54.72%   54.69%   -0.04%     
==========================================
  Files         213      213              
  Lines       16912    16920       +8     
  Branches     3337     3341       +4     
==========================================
- Hits         9255     9254       -1     
- Misses       7179     7186       +7     
- Partials      478      480       +2
Flag Coverage Δ
cube-backend 54.69% <9.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KSDaemon KSDaemon KSDaemon approved these changes

Assignees

@KSDaemon KSDaemon

Labels

data source driver driver:prestodb Issues relating to the PrestoDB driver javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorlukanin @KSDaemon