Skip to content

fix(api-gateway): Fix passing cacheMode from user's request #10162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(api-gateway): Fix passing cacheMode from user's request #10162

wants to merge 4 commits into from
+27 −17

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 20, 2025 •
edited
Loading

This PR fixes a bug when cache mode was not correctly processed during API request flow. Also this fixes a not-working no-cache mode.

Fixes: #10109

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.71%. Comparing base (258be19) to head (f3b7764).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 33.33% 2 Missing ⚠️
...-query-orchestrator/src/orchestrator/QueryCache.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (258be19) and HEAD (f3b7764). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (258be19) HEAD (f3b7764)
cubesql 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #10162       +/-   ##
===========================================
- Coverage   83.29%   54.71%   -28.58%     
===========================================
  Files         244      213       -31     
  Lines       74180    16914    -57266     
  Branches        0     3337     +3337     
===========================================
- Hits        61786     9255    -52531     
+ Misses      12394     7181     -5213     
- Partials        0      478      +478
Flag Coverage Δ
cube-backend 54.71% <57.14%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review November 20, 2025 19:33
@KSDaemon KSDaemon requested review from a team as code owners November 20, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

Assignees

No one assigned

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache control is not working as expected in v1.5.3 [BUG]

3 participants

@KSDaemon @ovr