fix(redshift-driver): Use Redshift-specific schema query. #3877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
rpaik
added
pre-aggregations
Contributor
|
cc/ @paveltiunov |
Member
|
@emmanuel Thanks for contributing that! Could you please fix TS compilation errors? |
Contributor
|
@emmanuel not sure if you saw @paveltiunov's comment 👆? |
Member
|
Closing in a favor of #9363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3876.
Check List
Issue Reference this PR resolves
Fixes #3876
Description of Changes Made (if issue reference is not provided)
Override
BaseDriver.createSchemaIfNotExists()inRedshiftDriverwith a schema-discovery query that is compatible with Redshift information schema permission semantics. See details in #3876.