-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(cubestore): Use seperate working loop for queue #6243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waralexrom
approved these changes
Mar 3, 2023
ee0f7d5 to
82780a4
Compare
82780a4 to
90c1c83
Compare
waralexrom
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a reusable read/write loop abstraction and applies it to both the core store and the cache queue.
- Introduces
RocksStoreRWLoopto encapsulate a blocking Tokio channel and processing loop. - Refactors
RocksStoreto usewrite_operation_impl/read_operation_implwith loop names in spans. - Updates
RocksCacheStoreto use a separaterw_loop_queue_cfand addswrite_operation_queue/read_operation_queue.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rust/cubestore/cubestore/src/metastore/rocks_store.rs | Added RocksStoreRWLoop, refactored read/write ops to use it. |
| rust/cubestore/cubestore/src/cachestore/cache_rocksstore.rs | Added queue-specific RW loop, replaced direct store calls. |
Comments suppressed due to low confidence (1)
rust/cubestore/cubestore/src/metastore/rocks_store.rs:808
- [nitpick] The
RocksStoreRWLoopstruct is public but lacks doc comments. Consider adding///comments to explain its purpose and usage.
#[derive(Debug, Clone)]
cd461cf to
9e66023
Compare
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
refs #5042
Thanks