fix(cubejs-schema-compiler): Stay unchanged __user / __cubejoinfield names in aliasing
#8303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
KSDaemon
force-pushed
the
bugfix-special-names-underscores
branch
from
d98511c to
4d29bcc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8303 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 230 230
Lines 85318 85315 -3
=======================================
+ Hits 71841 71842 +1
+ Misses 13477 13473 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MazterQyou
approved these changes
Jun 6, 2025
ovr
approved these changes
Jun 20, 2025
KSDaemon
force-pushed
the
bugfix-special-names-underscores
branch
from
5b7d33e to
54023f8
Compare
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…ld` names in aliasing (cube-js#8303) * dont change __user / __cubejoinfield names in aliasing * cast name to lower for `__cubeJoinField` case * reapply fix --------- Co-authored-by: Konstantin Burkalev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List