Skip to content

Conversation

@benyaminsalimi
Copy link
Contributor

@benyaminsalimi benyaminsalimi commented Jun 18, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Refactor duck-db driver: there is no need to install and load httpfs

@benyaminsalimi benyaminsalimi requested a review from a team as a code owner June 18, 2024 19:51
@vercel
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:32am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 18, 2024
@igorlukanin
Copy link
Member

Hi @benyaminsalimi 👋 Is it because httpfs will get autoloaded on first use? Was this behavior introduced in some recent version of DuckDB?

@benyaminsalimi
Copy link
Contributor Author

Indeed, but I don't know from which version but for current one.
You can see the details here

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thnx! Looks good!

@KSDaemon KSDaemon merged commit 0aee4fc into cube-js:master Nov 22, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver:duckdb pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants