Skip to content

feat(duckdb-driver): remove unnecessary installing and loading HttpFS extension #8375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat(duckdb-driver): remove unnecessary installing and loading HttpFS extension #8375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edebbe8
feat(duckdb-driver): Upgrade to DuckDB 1.0.0
benyaminsalimi Jun 18, 2024
d3310e9
feat(duckdb-driver): remove installing and loading httpfs extension
benyaminsalimi Jun 18, 2024
246b6b1
Merge branch 'master' into feat/refactor-duckdb-driver
KSDaemon Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions packages/cubejs-duckdb-driver/src/DuckDBDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,32 +81,6 @@ export class DuckDBDriver extends BaseDriver implements DriverInterface {
const defaultConnection = db.connect();
const execAsync: (sql: string, ...params: any[]) => Promise<void> = promisify(defaultConnection.exec).bind(defaultConnection) as any;

try {
await execAsync('INSTALL httpfs');
} catch (e) {
if (this.logger) {
console.error('DuckDB - error on httpfs installation', {
e
});
}

// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
throw e;
}

try {
await execAsync('LOAD httpfs');
} catch (e) {
if (this.logger) {
console.error('DuckDB - error on loading httpfs', {
e
});
}

// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
throw e;
}

const configuration = [
{
key: 's3_region',
Expand Down
Loading