refactor(cubesql): Extract cube join condition check for rewrites to separate function #8835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8835 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 221 221
Lines 78303 78318 +15
=======================================
+ Hits 64726 64742 +16
+ Misses 13577 13576 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
extract-cube-join-field-check
branch
from
4c845c8 to
476fe91
Compare
mcheshkov
force-pushed
the
extract-cube-join-field-check
branch
2 times, most recently
from
73e40f4 to
0ef06e4
Compare
mcheshkov
force-pushed
the
extract-cube-join-field-check
branch
from
0ef06e4 to
f3681ba
Compare
mcheshkov
force-pushed
the
extract-cube-join-field-check
branch
from
f3681ba to
4659f8c
Compare
Contributor
Author
|
Merged as part of #9032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.