Skip to content

fix(schema-compiler): Use member expression definition as measure key #9154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix(schema-compiler): Use member expression definition as measure key #9154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,6 +2100,7 @@ export class BaseQuery {
const cubeName = m.expressionCubeName ? `\`${m.expressionCubeName}\` ` : '';
throw new UserError(`The query contains \`COUNT(*)\` expression but cube/view ${cubeName}is missing \`count\` measure`);
}

if (collectedMeasures.length === 0 && m.isMemberExpression) {
// `m` is member expression measure, but does not reference any other measure
// Consider this dimensions-only measure. This can happen at least in 2 cases:
Expand All @@ -2110,8 +2111,17 @@ export class BaseQuery {
// TODO return measure object for every measure
return this.dimensionOnlyMeasureToHierarchy(context, m);
}
const measureName = typeof m.measure === 'string' ? m.measure : `${m.measure.cubeName}.${m.measure.name}`;
return [measureName, collectedMeasures];

let measureKey;
if (typeof m.measure === 'string') {
measureKey = m.measure;
} else if (m.isMemberExpression) {
// TODO expressionName vs definition?
measureKey = m.expressionName;
} else {
measureKey = `${m.measure.cubeName}.${m.measure.name}`;
}
return [measureKey, collectedMeasures];
}));
}

Expand Down
Loading