Skip to content

feat(cubesql): Remove bottom-up extraction completely #9183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(cubesql): Remove bottom-up extraction completely #9183

merged 1 commit into from
Apr 11, 2025

Conversation

@mcheshkov
Copy link
Contributor

@mcheshkov mcheshkov commented Feb 5, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (b5ddd11) to head (4a2838c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #9183       +/-   ##
===========================================
+ Coverage   47.87%   76.53%   +28.66%     
===========================================
  Files         171      400      +229     
  Lines       21422   104966    +83544     
  Branches     3712     3712               
===========================================
+ Hits        10255    80338    +70083     
- Misses      10730    24191    +13461     
  Partials      437      437
Flag Coverage Δ
cube-backend 47.87% <ø> (ø)
cubesql 83.88% <94.11%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov force-pushed the drop-bottom-up-cost branch from 26cf8ef to 0c7ab7c Compare March 12, 2025 19:54
@mcheshkov mcheshkov force-pushed the drop-bottom-up-cost branch 3 times, most recently from e2a6a55 to 780e116 Compare April 2, 2025 15:57
@mcheshkov mcheshkov marked this pull request as ready for review April 2, 2025 16:38
@mcheshkov mcheshkov requested a review from a team as a code owner April 2, 2025 16:38
@mcheshkov mcheshkov force-pushed the drop-bottom-up-cost branch from 780e116 to 407a4ba Compare April 4, 2025 12:53
@mcheshkov mcheshkov force-pushed the drop-bottom-up-cost branch from 407a4ba to 4a2838c Compare April 10, 2025 18:32
@KSDaemon KSDaemon merged commit c528ebe into master Apr 11, 2025
87 checks passed
@KSDaemon KSDaemon deleted the drop-bottom-up-cost branch April 11, 2025 08:29
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@mcheshkov @marianore-muttdata
feat(cubesql): Remove bottom-up extraction completely (cube-js#9183)
37a87da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcheshkov @ovr @KSDaemon