feat(pinot-driver): Add enableNullHandling=true to query options #9210
Conversation
| body: JSON.stringify({ | ||
| sql: query, | ||
| queryOptions: `useMultistageEngine=true;timeoutMs=${this.config.queryTimeout}` | ||
| queryOptions: `useMultistageEngine=true;enableNullHandling=true;timeoutMs=${this.config.queryTimeout}` |
There was a problem hiding this comment.
Hi @igorlukanin
Great, the configuration is correct. Is there a possibility to add this same setting as an environment variable?
Where its default value is false?
For example:
enableNullHandling=${this.config.dbNullHandling}; In: cube/packages/cubejs-pinot-driver/src/PinotDriver.ts
queryTimeout: getEnv('dbNullHandling', { dataSource }), So that I can set this variable like this:
CUBEJS_DS_PINOT_DB_NULL_HANDLING=trueThere was a problem hiding this comment.
@sergisulca I think this a great idea. Would you be open to contribute that? You can use this PR as a reference: #8744
…nv var (#9213) * Add enableNullHandling=true to query options using env var CUBEJS_DB_NULL_HANDLING * Add 'The Startree/Pinot null value support' to docs * fix reference env var * Update docs/pages/product/configuration/data-sources/pinot.mdx Co-authored-by: Konstantin Burkalev <[email protected]> * Update docs/pages/reference/configuration/environment-variables.mdx Co-authored-by: ron-damon <[email protected]> * Update docs/pages/reference/configuration/environment-variables.mdx Co-authored-by: ron-damon <[email protected]> * Update packages/cubejs-backend-shared/src/env.ts Co-authored-by: Konstantin Burkalev <[email protected]> * fix env var name --------- Co-authored-by: Konstantin Burkalev <[email protected]> Co-authored-by: ron-damon <[email protected]>
|
Superseded by #9213 |
|
Hi @igorlukanin , could it be that the changes were not merged into master? Since the Pull Request #9213 was applied to the branch of this PR (
|
Check List
Issue Reference this PR resolves
Requested in Slack: https://cubedevinc.slack.com/archives/C06FQNWFL7N/p1738790583282389?thread_ts=1730929644.841189&cid=C06FQNWFL7N