chore(tesseract): Some fixes to pass integration tests #9244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9244 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 228 228
Lines 82016 82016
=======================================
Hits 68640 68640
Misses 13376 13376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waralexrom
force-pushed
the
tesseract-fallback-to-js-on-pre-aggregations
branch
from
ab46752 to
cc70404
Compare
waralexrom
force-pushed
the
tesseract-some-tests-fix
branch
from
3a99bef to
e23eced
Compare
KSDaemon
approved these changes
Mar 3, 2025
| @@ -1,3 +1,4 @@ | |||
| import { getEnv } from '@cubejs-backend/shared'; | |||
| Ok(result) | ||
| } | ||
|
|
||
| fn deduplicate_deps_and_make_childs_tree( |
Member
There was a problem hiding this comment.
Suggested change
| fn deduplicate_deps_and_make_childs_tree( | |
| fn deduplicate_deps_and_make_children_tree( |
| &self, | ||
| call_deps: &Vec<CallDep>, | ||
| ) -> Result<Vec<Vec<usize>>, CubeError> { | ||
| let mut childs_tree = Vec::new(); |
Member
There was a problem hiding this comment.
Suggested change
| let mut childs_tree = Vec::new(); | |
| let mut children_tree = Vec::new(); |
| let mut deduplicate_index_map = HashMap::<usize, usize>::new(); | ||
| let mut deduplicate_map = HashMap::<CallDep, usize>::new(); | ||
| for (i, dep) in call_deps.iter().enumerate() { | ||
| //If subcube used twice in function, then call_deps can hold duplicated dependencies |
Member
There was a problem hiding this comment.
Suggested change
| //If subcube used twice in function, then call_deps can hold duplicated dependencies | |
| //If subcube is used twice in function, then call_deps can hold duplicated dependencies |
waralexrom
force-pushed
the
tesseract-fallback-to-js-on-pre-aggregations
branch
from
cc70404 to
10bdac5
Compare
Base automatically changed from
tesseract-fallback-to-js-on-pre-aggregations
to
master
March 3, 2025 13:48
waralexrom
force-pushed
the
tesseract-some-tests-fix
branch
from
e23eced to
403f3c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]