Skip to content

feat(cubeclient): Add short_title to dimensions and measures #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(cubeclient): Add short_title to dimensions and measures #9256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cubejs-api-gateway/openspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ components:
type: "string"
title:
type: "string"
shortTitle:
type: "string"
description:
type: "string"
type:
Expand All @@ -150,6 +152,8 @@ components:
type: "string"
title:
type: "string"
shortTitle:
type: "string"
description:
type: "string"
type:
Expand Down
3 changes: 3 additions & 0 deletions rust/cubesql/cubeclient/src/models/v1_cube_meta_dimension.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
pub name: String,
#[serde(rename = "title", skip_serializing_if = "Option::is_none")]
pub title: Option<String>,
#[serde(rename = "shortTitle", skip_serializing_if = "Option::is_none")]
pub short_title: Option<String>,
#[serde(rename = "description", skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
#[serde(rename = "type")]
Expand All @@ -32,6 +34,7 @@
V1CubeMetaDimension {
name,
title: None,
short_title: None,

Check warning on line 37 in rust/cubesql/cubeclient/src/models/v1_cube_meta_dimension.rs

View check run for this annotation

Codecov / codecov/patch

rust/cubesql/cubeclient/src/models/v1_cube_meta_dimension.rs#L37 

Added line #L37 was not covered by tests
description: None,
r#type,
alias_member: None,
Expand Down
3 changes: 3 additions & 0 deletions rust/cubesql/cubeclient/src/models/v1_cube_meta_measure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
pub name: String,
#[serde(rename = "title", skip_serializing_if = "Option::is_none")]
pub title: Option<String>,
#[serde(rename = "shortTitle", skip_serializing_if = "Option::is_none")]
pub short_title: Option<String>,
#[serde(rename = "description", skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
#[serde(rename = "type")]
Expand All @@ -29,6 +31,7 @@
V1CubeMetaMeasure {
name,
title: None,
short_title: None,

Check warning on line 34 in rust/cubesql/cubeclient/src/models/v1_cube_meta_measure.rs

View check run for this annotation

Codecov / codecov/patch

rust/cubesql/cubeclient/src/models/v1_cube_meta_measure.rs#L34 

Added line #L34 was not covered by tests
description: None,
r#type,
agg_type: None,
Expand Down
2 changes: 2 additions & 0 deletions rust/cubesql/cubesql/benches/large_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ pub fn get_large_model_test_meta(dims: usize) -> Vec<V1CubeMeta> {
V1CubeMetaMeasure {
name: format!("{}.count", cube_name),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("count".to_string()),
Expand All @@ -85,6 +86,7 @@ pub fn get_large_model_test_meta(dims: usize) -> Vec<V1CubeMeta> {
V1CubeMetaMeasure {
name: format!("{}.sum", cube_name),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("sum".to_string()),
Expand Down
27 changes: 27 additions & 0 deletions rust/cubesql/cubesql/src/compile/test/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.count".to_string(),
title: None,
short_title: None,
description: Some("Events count".to_string()),
r#type: "number".to_string(),
agg_type: Some("count".to_string()),
Expand All @@ -101,6 +102,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.maxPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("max".to_string()),
Expand All @@ -109,6 +111,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.sumPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("sum".to_string()),
Expand All @@ -117,6 +120,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.minPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("min".to_string()),
Expand All @@ -125,6 +129,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.avgPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("avg".to_string()),
Expand All @@ -133,6 +138,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "KibanaSampleDataEcommerce.countDistinct".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("countDistinct".to_string()),
Expand Down Expand Up @@ -189,6 +195,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "Logs.agentCount".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("countDistinct".to_string()),
Expand All @@ -197,6 +204,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "Logs.agentCountApprox".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("countDistinctApprox".to_string()),
Expand All @@ -221,6 +229,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
measures: vec![CubeMetaMeasure {
name: "NumberCube.someNumber".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("number".to_string()),
Expand Down Expand Up @@ -250,6 +259,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
r#type: "number".to_string(),
agg_type: Some("number".to_string()),
title: None,
short_title: None,
description: None,
meta: None,
})
Expand All @@ -258,6 +268,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "WideCube.count".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("count".to_string()),
Expand All @@ -266,6 +277,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "WideCube.maxPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("max".to_string()),
Expand All @@ -274,6 +286,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "WideCube.minPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("min".to_string()),
Expand All @@ -282,6 +295,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "WideCube.avgPrice".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("avg".to_string()),
Expand All @@ -290,6 +304,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "WideCube.countDistinct".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("countDistinct".to_string()),
Expand Down Expand Up @@ -342,6 +357,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
r#type: "number".to_string(),
agg_type: Some("number".to_string()),
title: None,
short_title: None,
description: Some(format!("Test number measure {i}")),
meta: None,
},
Expand All @@ -350,6 +366,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
r#type: "string".to_string(),
agg_type: Some("max".to_string()),
title: None,
short_title: None,
description: Some(format!("Test max(string) measure {i}")),
meta: None,
},
Expand All @@ -358,6 +375,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
r#type: "time".to_string(),
agg_type: Some("max".to_string()),
title: None,
short_title: None,
description: Some(format!("Test max(time) measure {i}")),
meta: None,
},
Expand All @@ -368,6 +386,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "MultiTypeCube.count".to_string(),
title: None,
short_title: None,
description: Some("Test count measure".to_string()),
r#type: "number".to_string(),
agg_type: Some("count".to_string()),
Expand All @@ -376,6 +395,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "MultiTypeCube.maxPrice".to_string(),
title: None,
short_title: None,
description: Some("Test maxPrice measure".to_string()),
r#type: "number".to_string(),
agg_type: Some("max".to_string()),
Expand All @@ -384,6 +404,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "MultiTypeCube.minPrice".to_string(),
title: None,
short_title: None,
description: Some("Test minPrice measure".to_string()),
r#type: "number".to_string(),
agg_type: Some("min".to_string()),
Expand All @@ -392,6 +413,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "MultiTypeCube.avgPrice".to_string(),
title: None,
short_title: None,
description: Some("Test avgPrice measure".to_string()),
r#type: "number".to_string(),
agg_type: Some("avg".to_string()),
Expand All @@ -400,6 +422,7 @@ pub fn get_test_meta() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "MultiTypeCube.countDistinct".to_string(),
title: None,
short_title: None,
description: Some("Test countDistinct measure".to_string()),
r#type: "number".to_string(),
agg_type: Some("countDistinct".to_string()),
Expand Down Expand Up @@ -428,6 +451,7 @@ pub fn get_string_cube_meta() -> Vec<CubeMeta> {
measures: vec![CubeMetaMeasure {
name: "StringCube.someString".to_string(),
title: None,
short_title: None,
description: None,
r#type: "string".to_string(),
agg_type: Some("string".to_string()),
Expand All @@ -452,6 +476,7 @@ pub fn get_sixteen_char_member_cube() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "SixteenChar.sixteen_charchar".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("sum".to_string()),
Expand All @@ -460,6 +485,7 @@ pub fn get_sixteen_char_member_cube() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "SixteenChar.sixteen_charchar_foo".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("avg".to_string()),
Expand All @@ -468,6 +494,7 @@ pub fn get_sixteen_char_member_cube() -> Vec<CubeMeta> {
CubeMetaMeasure {
name: "SixteenChar.sixteen_charchar_bar".to_string(),
title: None,
short_title: None,
description: None,
r#type: "number".to_string(),
agg_type: Some("count".to_string()),
Expand Down
Loading