fix(api-gateway): Support proxy when fetching jwk for token validation #9286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching the JWK data needed to validate the auth token, the environment proxy settings are not honored.
….com:stacklet/cube into stacklet-johnsca/fix/support-proxy-for-jwk-validation # Conflicts: # packages/cubejs-backend-shared/package.json
ovr
reviewed
Mar 5, 2025
ovr
approved these changes
Mar 5, 2025
Member
ovr
left a comment
ovr
left a comment
There was a problem hiding this comment.
Minor nit about cache for getHttpAgentForProxySettings, otherwise LGTM
KSDaemon
deleted the
stacklet-johnsca/fix/support-proxy-for-jwk-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes the original one made by @johnsca with conflict resolution and some improvements.
Check List
Closes #9013