Skip to content

fix(schema-compiler): Fix BigQuery DATE_ADD push down template for years/quarters/months #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2025
Merged

fix(schema-compiler): Fix BigQuery DATE_ADD push down template for years/quarters/months #9432

merged 6 commits into from
Apr 8, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 7, 2025 •
edited
Loading

This fixes the BigQuery dateadd/timestampadd functions genereation, because of:
TIMESTAMP_ADD doesn't support YEAR interval.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.85629% with 47 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (452633c) to head (7c06958).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 36.66% 38 Missing ⚠️
...ubejs-schema-compiler/src/adapter/BigqueryQuery.ts 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9432      +/-   ##
==========================================
+ Coverage   76.40%   76.48%   +0.07%     
==========================================
  Files         400      400              
  Lines      104055   104200     +145     
  Branches     3685     3687       +2     
==========================================
+ Hits        79508    79696     +188     
+ Misses      24112    24069      -43     
  Partials      435      435
Flag Coverage Δ
cube-backend 47.86% <0.00%> (-0.02%) ⬇️
cubesql 83.84% <75.94%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 8, 2025 11:07
@KSDaemon KSDaemon requested review from a team as code owners April 8, 2025 11:07
@KSDaemon KSDaemon merged commit 5845c88 into master Apr 8, 2025
78 checks passed
@KSDaemon KSDaemon deleted the fix/bg-timeshift branch April 8, 2025 12:21
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@KSDaemon @marianore-muttdata
fix(schema-compiler): Fix BigQuery DATE_ADD push down template for ye…
9d821cc 
…ars/quarters/months (cube-js#9432)

* fix(schema-compiler): Fix BigQuery DATE_ADD push down template for years/quarters/months

* add tests for BQ date_add

* fix tests

* add interval + date_part for date_add udf

* fix template

* add/fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MazterQyou MazterQyou MazterQyou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KSDaemon @MazterQyou