Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Apr 16, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner April 16, 2025 20:53
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (9b50157) to head (f8ee89b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9b50157) and HEAD (f8ee89b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9b50157) HEAD (f8ee89b)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9484       +/-   ##
===========================================
- Coverage   83.88%   58.46%   -25.43%     
===========================================
  Files         229      167       -62     
  Lines       83544    14927    -68617     
  Branches        0     2955     +2955     
===========================================
- Hits        70083     8727    -61356     
+ Misses      13461     5854     -7607     
- Partials        0      346      +346     
Flag Coverage Δ
cube-backend 58.46% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paveltiunov paveltiunov merged commit b8de1a4 into master Apr 16, 2025
32 checks passed
@paveltiunov paveltiunov deleted the client-network-retries branch April 16, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants