Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 23, 2025

Makes it possible to inherit some views from others.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.52%. Comparing base (4697600) to head (b331432).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 93.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9507      +/-   ##
==========================================
+ Coverage   58.47%   58.52%   +0.04%     
==========================================
  Files         169      169              
  Lines       13990    14002      +12     
  Branches     2275     2282       +7     
==========================================
+ Hits         8180     8194      +14     
+ Misses       5495     5493       -2     
  Partials      315      315              
Flag Coverage Δ
cube-backend 58.52% <94.11%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon changed the title feat(schema-compiler): Support folders via views extends feat(schema-compiler): Support view extends Apr 23, 2025
@KSDaemon KSDaemon force-pushed the feat/views-extends-folders branch from 41b634b to 60e8526 Compare April 24, 2025 18:32
@KSDaemon KSDaemon marked this pull request as ready for review April 25, 2025 11:07
@KSDaemon KSDaemon requested a review from a team as a code owner April 25, 2025 11:07
@KSDaemon KSDaemon force-pushed the feat/views-extends-folders branch from e1c714f to 371238d Compare April 26, 2025 15:50
@KSDaemon KSDaemon merged commit e68530a into master Apr 28, 2025
59 checks passed
@KSDaemon KSDaemon deleted the feat/views-extends-folders branch April 28, 2025 10:18
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* restructure validation schemas (for hierarchies and folders)

* remove unneeded

* feat(schema-compiler): Support folders via views extends

* tests fix/improve

* make extend of all the things in the view

* update tests

* upd tests

* Add docs

* update snapshot

---------

Co-authored-by: Igor Lukanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants