Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 8, 2025

This PR fixes incorrect SQL generation for queries that reference view members with timeShift from joined cubes

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (20dd8ad) to head (f9cdfa7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9556   +/-   ##
=======================================
  Coverage   61.74%   61.75%           
=======================================
  Files         174      174           
  Lines       14431    14434    +3     
  Branches     2464     2464           
=======================================
+ Hits         8910     8913    +3     
  Misses       5155     5155           
  Partials      366      366           
Flag Coverage Δ
cube-backend 61.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review May 8, 2025 16:13
@KSDaemon KSDaemon requested a review from a team as a code owner May 8, 2025 16:13
@KSDaemon KSDaemon merged commit ef3a04b into master May 8, 2025
61 checks passed
@KSDaemon KSDaemon deleted the fix/timeshift-in-views branch May 8, 2025 16:49
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…s#9556)

* fix(schema-compiler): Fix view queries with timeShift members

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants