Skip to content

fix(schema-compiler): exclude time dimensions w/o granularities from select list in base queries #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

fix(schema-compiler): exclude time dimensions w/o granularities from select list in base queries #9614

merged 4 commits into from
May 23, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 23, 2025 •
edited
Loading

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review May 23, 2025 13:59
@KSDaemon KSDaemon requested a review from a team as a code owner May 23, 2025 13:59
@KSDaemon KSDaemon changed the title fix(schema-compiler): exclude time dimension w/o granularities from select list in base queries fix(schema-compiler): exclude time dimensions w/o granularities from select list in base queries May 23, 2025
@KSDaemon KSDaemon merged commit c9ebfbc into master May 23, 2025
64 checks passed
@KSDaemon KSDaemon deleted the fix/timedims-no-gran-filters branch May 23, 2025 14:00
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@KSDaemon @marianore-muttdata
fix(schema-compiler): exclude time dimensions w/o granularities from …
45afcd8 
…select list in base queries (cube-js#9614)

* typings and linter fixes

* fix(schema-compiler): exclude time dimension w/o granularities from select list in base queries

* some tests refactoring

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waralexrom waralexrom waralexrom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KSDaemon @waralexrom