fix(cubesql): Quote subquery joins alias in SQL push down to cube #9629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9629 +/- ##
==========================================
- Coverage 84.14% 84.14% -0.01%
==========================================
Files 230 230
Lines 84622 84625 +3
==========================================
+ Hits 71205 71207 +2
- Misses 13417 13418 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MazterQyou
force-pushed
the
cubesql/cube-join-quote-identifier
branch
from
3f65152 to
dee0b78
Compare
Co-authored-by: Konstantin Burkalev <[email protected]>
MazterQyou
force-pushed
the
cubesql/cube-join-quote-identifier
branch
from
dee0b78 to
b732d08
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…be-js#9629) Co-authored-by: Konstantin Burkalev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR quotes join aliases as identifiers when generating SQL for SQL push down to cube. Related test is included.