Skip to content

Conversation

@raosudheesh
Copy link
Contributor

@raosudheesh raosudheesh commented May 29, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#9632

Description of Changes Made (if issue reference is not provided)

  • Implement quarter granularity in SqliteQuery with explicit CASE to map months to their respective quarter start dates.
  • Aligns SQLite quarter handling with Postgres DATE_TRUNC('quarter', ...)
  • Fixes issues with data blending queries requiring quarter granularity.

- Implement quarter granularity in SqliteQuery with explicit CASE
  to map months to their respective quarter start dates.
- Aligns SQLite quarter handling with Postgres DATE_TRUNC('quarter', ...)
- Fixes issues with data blending queries requiring quarter granularity.
@raosudheesh raosudheesh requested a review from a team as a code owner May 29, 2025 19:46
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 29, 2025
@KSDaemon
Copy link
Member

@raosudheesh Thank you for your contribution! Please run yarn run lint:fix to fix linting errors.

@raosudheesh
Copy link
Contributor Author

raosudheesh commented May 30, 2025

@raosudheesh Thank you for your contribution! Please run yarn run lint:fix to fix linting errors.

@KSDaemon fixed the lining issue here: 23b254d

Is there anyway we can fast track this PR. Would be helpful, thanks

@raosudheesh
Copy link
Contributor Author

@KSDaemon Could you help me with this test failing?

@KSDaemon
Copy link
Member

@raosudheesh no worries. It seems not to be related to your changes... I'll give it another try...

@raosudheesh
Copy link
Contributor Author

@raosudheesh no worries. It seems not to be related to your changes... I'll give it another try...

Sure thanks!

@KSDaemon KSDaemon merged commit c7ae936 into cube-js:master May 30, 2025
138 of 142 checks passed
@raosudheesh
Copy link
Contributor Author

@KSDaemon Thanks for the swift action on merging my PR. Looking forward to making more upstream contributions.

@KSDaemon
Copy link
Member

@raosudheesh NP! You're welcome! Once again thank you for your contribution!

@shrikrishnaholla
Copy link

@KSDaemon really appreciate the proactive engagement and quick turnaround! 🙏 🥇

@raosudheesh raosudheesh deleted the feat/sqlite-quarter-granularity branch June 2, 2025 19:18
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
… using CASE expression (cube-js#9633)

* feat(sqlite): add quarter granularity support using CASE expression

- Implement quarter granularity in SqliteQuery with explicit CASE
  to map months to their respective quarter start dates.
- Aligns SQLite quarter handling with Postgres DATE_TRUNC('quarter', ...)
- Fixes issues with data blending queries requiring quarter granularity.

* fixed the lint fail issue

* removed the unnecessary .trim() function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants