-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(sqlite): add quarter granularity support using CASE expression #9633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlite): add quarter granularity support using CASE expression #9633
Conversation
- Implement quarter granularity in SqliteQuery with explicit CASE
to map months to their respective quarter start dates.
- Aligns SQLite quarter handling with Postgres DATE_TRUNC('quarter', ...)
- Fixes issues with data blending queries requiring quarter granularity.
|
@raosudheesh Thank you for your contribution! Please run |
@KSDaemon fixed the lining issue here: 23b254d Is there anyway we can fast track this PR. Would be helpful, thanks |
|
@KSDaemon Could you help me with this test failing? |
|
@raosudheesh no worries. It seems not to be related to your changes... I'll give it another try... |
Sure thanks! |
|
@KSDaemon Thanks for the swift action on merging my PR. Looking forward to making more upstream contributions. |
|
@raosudheesh NP! You're welcome! Once again thank you for your contribution! |
|
@KSDaemon really appreciate the proactive engagement and quick turnaround! 🙏 🥇 |
… using CASE expression (cube-js#9633) * feat(sqlite): add quarter granularity support using CASE expression - Implement quarter granularity in SqliteQuery with explicit CASE to map months to their respective quarter start dates. - Aligns SQLite quarter handling with Postgres DATE_TRUNC('quarter', ...) - Fixes issues with data blending queries requiring quarter granularity. * fixed the lint fail issue * removed the unnecessary .trim() function
Check List
Issue Reference this PR resolves
#9632
Description of Changes Made (if issue reference is not provided)