Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 20, 2025

This brings new type of cubes: calendar cubes and support for custom sql() in granularities.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon force-pushed the feat/calendar-table-models branch from 45b9144 to 674dde7 Compare June 20, 2025 19:20
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.18%. Comparing base (525932c) to head (9b653bd).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9698   +/-   ##
=======================================
  Coverage   84.17%   84.18%           
=======================================
  Files         230      230           
  Lines       85149    85149           
=======================================
+ Hits        71676    71684    +8     
+ Misses      13473    13465    -8     
Flag Coverage Δ
cubesql 84.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review June 24, 2025 09:47
@KSDaemon KSDaemon requested a review from a team as a code owner June 24, 2025 09:47
@KSDaemon KSDaemon force-pushed the feat/calendar-table-models branch from a05d8aa to 9b653bd Compare June 24, 2025 09:52
@KSDaemon KSDaemon merged commit 40b3708 into master Jun 26, 2025
110 of 112 checks passed
@KSDaemon KSDaemon deleted the feat/calendar-table-models branch June 26, 2025 08:43
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
…ube-js#9698)

* add support for calendar prop and sql in granularities in schema validator

* fix resolveGranularity() for calendar td granularities

* support granularities sql() in tesseract

* fix td symbol deps

* cargo fmt

* add tests for calendar cubes in schema compiler

* add calendar tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants