Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 1, 2025

This PR brings support for custom granularities in rolling window measures.

Also includes:

  • add missing quarter to SqlInterval

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (834d381) to head (06803a2).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9739       +/-   ##
===========================================
+ Coverage        0   84.21%   +84.21%     
===========================================
  Files           0      231      +231     
  Lines           0    85472    +85472     
===========================================
+ Hits            0    71983    +71983     
- Misses          0    13489    +13489     
Flag Coverage Δ
cubesql 84.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review July 1, 2025 18:33
@KSDaemon KSDaemon requested a review from a team as a code owner July 1, 2025 18:33
@KSDaemon KSDaemon merged commit a8b611c into master Jul 2, 2025
82 checks passed
@KSDaemon KSDaemon deleted the feat/custom-granularities-in-to_date_rolling branch July 2, 2025 08:36
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
…ows (cube-js#9739)

* remove useless comment

* implement baseQuery's dimensionTimeGroupedColumn() in Granularity object

* Use Granularity obj in ToDateRollingWindowJoinCondition

* add missing quarter to SqlInterval

* cargo fmt

* add support for custom granularities to base filter

* add tests

* cargo fmt

* skip tests for basequery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants