Skip to content

feat(tesseract): Support for time shifts over calendar cubes dimensions #9758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2025
Merged

feat(tesseract): Support for time shifts over calendar cubes dimensions #9758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d513eb7
update data model scheme for calendar time shifts + compilation tests
KSDaemon Jun 24, 2025
cc2c894
chore(tesseract): Refactoring of time shift without time dimension logic
waralexrom Jul 3, 2025
a474838
add timeshift definitions to rust side
KSDaemon Jul 7, 2025
48b7f5b
implement time shifts over calendar tables
KSDaemon Jul 7, 2025
b12d4ed
add usefull comment
KSDaemon Jul 8, 2025
fbd5fdc
fix correct sql gen for calendar custom gran but with common timeshift
KSDaemon Jul 9, 2025
f3c874d
add tests
KSDaemon Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/cubejs-schema-compiler/src/compiler/CubeValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ const timeShiftItemRequired = Joi.object({
});

const timeShiftItemOptional = Joi.object({
timeDimension: Joi.func(), // не required
timeDimension: Joi.func(), // not required
interval: regexTimeInterval.required(),
type: Joi.string().valid('next', 'prior').required(),
});
Expand Down Expand Up @@ -661,6 +661,17 @@ const DimensionsSchema = Joi.object().pattern(identifierRegex, Joi.alternatives(
type: Joi.any().valid('number').required(),
sql: Joi.func().required(),
addGroupBy: Joi.func(),
}),
// TODO should be valid only for calendar cubes, but this requires significant refactoring
// of all schemas. Left for the future when we'll switch to zod.
inherit(BaseDimensionWithoutSubQuery, {
type: Joi.any().valid('time').required(),
sql: Joi.func().required(),
timeShift: Joi.array().items(Joi.object({
interval: regexTimeInterval.required(),
type: Joi.string().valid('next', 'prior').required(),
sql: Joi.func().required(),
})),
})
));

Expand Down
Loading
Loading