Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes issues with rewrites not working correctly when granularities in EXTRACT, DATE_PART, or DATE_TRUNC functions are not of the letter case expected by some rewrite rules by normalizing the granularities across all plans. Related tests are adjusted.

@MazterQyou MazterQyou requested a review from a team as a code owner July 7, 2025 20:50
@MazterQyou MazterQyou force-pushed the cubesql/normalize-granularities branch from 43e9302 to bd1e04a Compare July 7, 2025 20:55
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 80.52910% with 184 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (93a4dcb) to head (bd1e04a).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...src/compile/engine/df/optimizers/plan_normalize.rs 85.68% 123 Missing ⚠️
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 61 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9759    +/-   ##
========================================
  Coverage   84.25%   84.26%            
========================================
  Files         231      232     +1     
  Lines       85650    86443   +793     
========================================
+ Hits        72163    72838   +675     
- Misses      13487    13605   +118     
Flag Coverage Δ
cubesql 84.26% <80.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 2db54ba into master Jul 8, 2025
82 checks passed
@MazterQyou MazterQyou deleted the cubesql/normalize-granularities branch July 8, 2025 15:13
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants