Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 11, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon force-pushed the feat/named-time-shifts branch from 3739c78 to 1e9a63e Compare July 11, 2025 16:53
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (3f16a39) to head (9617c3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9773      +/-   ##
==========================================
- Coverage   84.28%   84.27%   -0.01%     
==========================================
  Files         233      233              
  Lines       86704    86704              
==========================================
- Hits        73075    73071       -4     
- Misses      13629    13633       +4     
Flag Coverage Δ
cubesql 84.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review July 14, 2025 11:35
@KSDaemon KSDaemon requested a review from a team as a code owner July 14, 2025 11:35
@KSDaemon KSDaemon requested a review from waralexrom July 14, 2025 11:35
@KSDaemon KSDaemon merged commit e033aaf into master Jul 14, 2025
82 checks passed
@KSDaemon KSDaemon deleted the feat/named-time-shifts branch July 14, 2025 13:25
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
…calendars (cube-js#9773)

* extend cube validator to support named timeshifts

* Initial support for named time shifts

* Resolve conficts

* fix Evaluator to support named time shifts

* update measure symbol to support named time shifts

* cargo clippy

* update snapshots

* add tests for named time shifts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants