Update linting, add CI, and fix up some things.

Author: lgarron

.github/workflows/CI.yaml

@@ -0,0 +1,13 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - uses: oven-sh/setup-bun@v1
+      - run: make setup
+      - run: make lint

Makefile

@@ -10,6 +10,7 @@ dev: setup
 .PHONY: lint
 lint: setup
 	bun x @biomejs/biome check
+	bun x tsc --noEmit --project .
 
 .PHONY: format
 format: setup

biome.json

@@ -1,26 +1,7 @@
 {
   "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": ["./node_modules/@cubing/dev-config/biome/biome.json"],
   "files": {
     "includes": ["**", "!dist", "!package.json"]
-  },
-  "formatter": {
-    "indentStyle": "space",
-    "indentWidth": 2
-  },
-  "linter": {
-    "rules": {
-      "style": {
-        "noParameterAssign": "error",
-        "useAsConstAssertion": "error",
-        "useDefaultParameterLast": "error",
-        "useEnumInitializers": "error",
-        "useSelfClosingElements": "error",
-        "useSingleVarDeclarator": "error",
-        "noUnusedTemplateLiteral": "error",
-        "useNumberNamespace": "error",
-        "noInferrableTypes": "error",
-        "noUselessElse": "error"
-      }
-    }
   }
 }

bun.lock

@@ -13,6 +13,7 @@
   },
   "devDependencies": {
     "@biomejs/biome": "^2.0.6",
+    "@cubing/dev-config": "^0.3.6",
     "@types/bun": "^1.2.17",
     "barely-a-dev-server": "^0.8.1",
     "esbuild": "^0.25.5"

package.json

@@ -31,7 +31,7 @@ export async function listFiles(
   );
 
   const ownMatches = [];
-  let recursiveMatches = [];
+  let recursiveMatches: string[] = [];
   for (const childName of childNames) {
     const newRelativePath = relativePath
       ? join(relativePath, childName)
@@ -47,7 +47,7 @@ export async function listFiles(
   return ownMatches.concat(recursiveMatches);
 }
 
-const hashes = {};
+const hashes: Record<string, string> = {};
 for (const path of await listFiles(
   ADDON_DIST_DIR,
   (name) => name !== ".DS_Store" && !name.endsWith("/.DS_Store"),

script/build.ts

@@ -1,7 +1,3 @@
 {
-  "compilerOptions": {
-    "target": "es2022",
-    "module": "es2022",
-    "moduleResolution": "bundler"
-  }
+  "extends": "./tsconfig.jsonc"
 }

tsconfig.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "extends": "./node_modules/@cubing/dev-config/ts/es2022-types/tsconfig.json",
+  "compilerOptions": {
+    // TODO: this should not be necessary. `@types/node` and `@types/bun` have been compatible for a while, and we're avoiding other dependency versions that would mess with that.
+    "skipLibCheck": true
+  }
+}