Skip to content

Commit b62c523

Browse files
committed
Remove duplicates
1 parent 1c96be2 commit b62c523

File tree

5 files changed

+29
-50
lines changed

5 files changed

+29
-50
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
package io.cucumber.cucumberexpressions;
2+
3+
import org.assertj.core.api.AbstractObjectAssert;
4+
import org.assertj.core.api.InstanceOfAssertFactories;
5+
6+
import java.util.List;
7+
import java.util.Optional;
8+
9+
import static org.assertj.core.api.Assertions.assertThat;
10+
11+
final class Assertions {
12+
13+
private Assertions(){
14+
// utility class
15+
}
16+
17+
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
18+
static AbstractObjectAssert<?, Object> asserThatSingleArgumentValue(Optional<List<Argument<?>>> match) {
19+
return assertThat(match).get()
20+
.asInstanceOf(InstanceOfAssertFactories.LIST)
21+
.map(Argument.class::cast)
22+
.singleElement()
23+
.extracting(Argument::getValue);
24+
}
25+
}

java/src/test/java/io/cucumber/cucumberexpressions/CustomParameterTypeTest.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.cucumber.cucumberexpressions;
22

3-
import org.assertj.core.api.AbstractObjectAssert;
43
import org.assertj.core.api.InstanceOfAssertFactories;
54
import org.jspecify.annotations.Nullable;
65
import org.junit.jupiter.api.BeforeEach;
@@ -12,6 +11,7 @@
1211
import java.util.Optional;
1312
import java.util.regex.Pattern;
1413

14+
import static io.cucumber.cucumberexpressions.Assertions.asserThatSingleArgumentValue;
1515
import static java.lang.Integer.parseInt;
1616
import static java.util.Arrays.asList;
1717
import static java.util.Objects.requireNonNull;
@@ -230,15 +230,6 @@ void matches_RegularExpression_arguments_with_custom_parameter_type_without_name
230230
private static void getArgumentValue(Optional<List<Argument<?>>> match, int index) {
231231
match.ifPresent(arguments -> arguments.get(index).getValue());
232232
}
233-
234-
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
235-
private static AbstractObjectAssert<?, Object> asserThatSingleArgumentValue(Optional<List<Argument<?>>> match) {
236-
return assertThat(match).get()
237-
.asInstanceOf(InstanceOfAssertFactories.LIST)
238-
.map(Argument.class::cast)
239-
.singleElement()
240-
.extracting(Argument::getValue);
241-
}
242233

243234
private record Coordinate(int x, int y, int z) {
244235

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
package io.cucumber.cucumberexpressions;
22

3-
import org.assertj.core.api.AbstractObjectAssert;
4-
import org.assertj.core.api.InstanceOfAssertFactories;
53
import org.junit.jupiter.api.Test;
64

7-
import java.util.List;
85
import java.util.Locale;
9-
import java.util.Optional;
106

11-
import static org.assertj.core.api.Assertions.assertThat;
7+
import static io.cucumber.cucumberexpressions.Assertions.asserThatSingleArgumentValue;
128

139
class EnumParameterTypeTest {
1410

@@ -27,14 +23,4 @@ void converts_to_enum() {
2723
var args = expression.match("I am happy");
2824
asserThatSingleArgumentValue(args).isEqualTo(Mood.happy);
2925
}
30-
31-
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
32-
private static AbstractObjectAssert<?, Object> asserThatSingleArgumentValue(Optional<List<Argument<?>>> match) {
33-
return assertThat(match).get()
34-
.asInstanceOf(InstanceOfAssertFactories.LIST)
35-
.map(Argument.class::cast)
36-
.singleElement()
37-
.extracting(Argument::getValue);
38-
}
39-
4026
}

java/src/test/java/io/cucumber/cucumberexpressions/GenericParameterTypeTest.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
package io.cucumber.cucumberexpressions;
22

3-
import org.assertj.core.api.AbstractObjectAssert;
4-
import org.assertj.core.api.InstanceOfAssertFactories;
53
import org.jspecify.annotations.Nullable;
64
import org.junit.jupiter.api.Test;
75

86
import java.util.List;
97
import java.util.Locale;
10-
import java.util.Optional;
118

9+
import static io.cucumber.cucumberexpressions.Assertions.asserThatSingleArgumentValue;
1210
import static java.util.Arrays.asList;
1311
import static java.util.Collections.singletonList;
1412
import static java.util.Objects.requireNonNull;
15-
import static org.assertj.core.api.Assertions.assertThat;
1613

1714
public class GenericParameterTypeTest {
1815

@@ -33,12 +30,4 @@ public void transforms_to_a_list_of_string() {
3330
asserThatSingleArgumentValue(args).isEqualTo(asList("three", "blind", "mice"));
3431
}
3532

36-
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
37-
private static AbstractObjectAssert<?, Object> asserThatSingleArgumentValue(Optional<List<Argument<?>>> match) {
38-
return assertThat(match).get()
39-
.asInstanceOf(InstanceOfAssertFactories.LIST)
40-
.map(Argument.class::cast)
41-
.singleElement()
42-
.extracting(Argument::getValue);
43-
}
4433
}

java/src/test/java/io/cucumber/cucumberexpressions/ParameterTypeRegistryTest.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
package io.cucumber.cucumberexpressions;
22

3-
import org.assertj.core.api.AbstractObjectAssert;
4-
import org.assertj.core.api.InstanceOfAssertFactories;
53
import org.jspecify.annotations.Nullable;
64
import org.junit.jupiter.api.Test;
75
import org.junit.jupiter.api.function.Executable;
86

97
import java.math.BigDecimal;
10-
import java.util.List;
118
import java.util.Locale;
12-
import java.util.Optional;
139
import java.util.regex.Pattern;
1410

11+
import static io.cucumber.cucumberexpressions.Assertions.asserThatSingleArgumentValue;
1512
import static org.assertj.core.api.Assertions.assertThat;
1613
import static org.junit.jupiter.api.Assertions.assertNotNull;
1714
import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -171,15 +168,6 @@ public void parse_decimal_numbers_in_norwegian() {
171168
asserThatSingleArgumentValue(expression.match("-1,1")).isEqualTo(new BigDecimal("-1.1"));
172169
asserThatSingleArgumentValue(expression.match("-,1E1")).isEqualTo(new BigDecimal("-1"));
173170
}
174-
175-
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
176-
private static AbstractObjectAssert<?, Object> asserThatSingleArgumentValue(Optional<List<Argument<?>>> match) {
177-
return assertThat(match).get()
178-
.asInstanceOf(InstanceOfAssertFactories.LIST)
179-
.map(Argument.class::cast)
180-
.singleElement()
181-
.extracting(Argument::getValue);
182-
}
183171

184172
public static class Name {
185173
Name(@Nullable String s) {

0 commit comments

Comments
 (0)