From 3d744670186cedb6cd85666dcfbb38e5d593dbca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gasterst=C3=A4dt?= <157380642+antagoony@users.noreply.github.com> Date: Sun, 23 Nov 2025 22:36:31 +0100 Subject: [PATCH 1/4] public KeyboardFriendlyDecimalFormatSymbols enables custom reuse --- CHANGELOG.md | 3 +++ .../KeyboardFriendlyDecimalFormatSymbols.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a22f06f1c..65e67131d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/). - [Ruby] Minor cosmetic / CI changes for development (Nothing front-facing) - [Python] PEP 639 licence metadata specification ([#361](https://github.com/cucumber/cucumber-expressions/pull/361)) - [Java] Add OSGi metadata +- [Java] class `KeyboardFriendlyDecimalFormatSymbols` is now `public` and can be used when creating a custom `Locale`-aware type transformation method +([#376](https://github.com/cucumber/cucumber-expressions/issues/376) +[antagoony](https://github.com/antagoony)) ### Removed - [Python] Remove support for end-of-life Python 3.8 and 3.9 ([#359](https://github.com/cucumber/cucumber-expressions/pull/359)) diff --git a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java index 39b5e07b5..1ae89c6f2 100644 --- a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java +++ b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java @@ -8,9 +8,9 @@ *

* Note quite complete, feel free to make a suggestion. */ -class KeyboardFriendlyDecimalFormatSymbols { +public class KeyboardFriendlyDecimalFormatSymbols { - static DecimalFormatSymbols getInstance(Locale locale) { + public static DecimalFormatSymbols getInstance(Locale locale) { DecimalFormatSymbols symbols = DecimalFormatSymbols.getInstance(locale); // Replace the minus sign with minus-hyphen as available on most keyboards. From bab8f8d72dbd334b9d3b51a2a26588c0e9b54acf Mon Sep 17 00:00:00 2001 From: antagoony <157380642+antagoony@users.noreply.github.com> Date: Mon, 24 Nov 2025 15:52:32 +0100 Subject: [PATCH 2/4] Apply suggestions from code review Co-authored-by: M.P. Korstanje --- CHANGELOG.md | 1 + .../KeyboardFriendlyDecimalFormatSymbols.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 65e67131d..a9462b5c2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). - [Ruby] Minor cosmetic / CI changes for development (Nothing front-facing) - [Python] PEP 639 licence metadata specification ([#361](https://github.com/cucumber/cucumber-expressions/pull/361)) - [Java] Add OSGi metadata +### Added - [Java] class `KeyboardFriendlyDecimalFormatSymbols` is now `public` and can be used when creating a custom `Locale`-aware type transformation method ([#376](https://github.com/cucumber/cucumber-expressions/issues/376) [antagoony](https://github.com/antagoony)) diff --git a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java index 1ae89c6f2..c12625c61 100644 --- a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java +++ b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java @@ -8,7 +8,7 @@ *

* Note quite complete, feel free to make a suggestion. */ -public class KeyboardFriendlyDecimalFormatSymbols { +public final class KeyboardFriendlyDecimalFormatSymbols { public static DecimalFormatSymbols getInstance(Locale locale) { DecimalFormatSymbols symbols = DecimalFormatSymbols.getInstance(locale); From d439e244bd6c5084791d26f8c4b37fdba40b7bfa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gasterst=C3=A4dt?= <157380642+antagoony@users.noreply.github.com> Date: Mon, 24 Nov 2025 15:58:08 +0100 Subject: [PATCH 3/4] put changelog entry on a single line --- CHANGELOG.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a9462b5c2..bf483c163 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,9 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). - [Python] PEP 639 licence metadata specification ([#361](https://github.com/cucumber/cucumber-expressions/pull/361)) - [Java] Add OSGi metadata ### Added -- [Java] class `KeyboardFriendlyDecimalFormatSymbols` is now `public` and can be used when creating a custom `Locale`-aware type transformation method -([#376](https://github.com/cucumber/cucumber-expressions/issues/376) -[antagoony](https://github.com/antagoony)) +- [Java] class `KeyboardFriendlyDecimalFormatSymbols` is now `public` and can be used when creating a custom `Locale`-aware type transformation method ([#376](https://github.com/cucumber/cucumber-expressions/issues/376) [antagoony](https://github.com/antagoony)) ### Removed - [Python] Remove support for end-of-life Python 3.8 and 3.9 ([#359](https://github.com/cucumber/cucumber-expressions/pull/359)) From 2ff842fa0b9facc99eadf1fc6ecb86a227a26c9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gasterst=C3=A4dt?= <157380642+antagoony@users.noreply.github.com> Date: Mon, 24 Nov 2025 18:23:08 +0100 Subject: [PATCH 4/4] add "@API(status = API.Status.EXPERIMENTAL)" --- .../KeyboardFriendlyDecimalFormatSymbols.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java index c12625c61..1911b95cf 100644 --- a/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java +++ b/java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java @@ -1,5 +1,7 @@ package io.cucumber.cucumberexpressions; +import org.apiguardian.api.API; + import java.text.DecimalFormatSymbols; import java.util.Locale; @@ -8,6 +10,7 @@ *

* Note quite complete, feel free to make a suggestion. */ +@API(status = API.Status.EXPERIMENTAL) public final class KeyboardFriendlyDecimalFormatSymbols { public static DecimalFormatSymbols getInstance(Locale locale) {