Skip to content

Commit 4692312

Browse files
committed
Remove ConsoleLauncher from examples
Keep the examples focused on one thing
1 parent 5e44576 commit 4692312

File tree

4 files changed

+8
-74
lines changed

4 files changed

+8
-74
lines changed

calculator-java-junit-jupiter/pom.xml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -101,40 +101,6 @@
101101
</properties>
102102
</configuration>
103103
</plugin>
104-
105-
<plugin>
106-
<groupId>org.apache.maven.plugins</groupId>
107-
<artifactId>maven-antrun-plugin</artifactId>
108-
<version>3.2.0</version>
109-
<executions>
110-
<execution>
111-
<!-- Work around. Surefire does not use JUnits Test Engine discovery functionality.
112-
113-
Alternatively use the JUnit Platform Suite Engine.
114-
-->
115-
<id>cli-test</id>
116-
<phase>test</phase>
117-
<goals>
118-
<goal>run</goal>
119-
</goals>
120-
<configuration>
121-
<target unless="maven.test.skip">
122-
<echo message="Running JUnit Platform CLI" level="info" />
123-
<java classname="org.junit.platform.console.ConsoleLauncher" fork="true"
124-
failonerror="true" newenvironment="true" maxmemory="512m"
125-
classpathref="maven.test.classpath">
126-
<arg value="--include-engine"/>
127-
<arg value="cucumber"/>
128-
<arg value="--scan-classpath"/>
129-
<arg value="${project.build.testOutputDirectory}"/>
130-
<arg value="--reports-dir"/>
131-
<arg value="${project.build.directory}/cucumber-reports"/>
132-
</java>
133-
</target>
134-
</configuration>
135-
</execution>
136-
</executions>
137-
</plugin>
138104
</plugins>
139105
</build>
140106
</project>

calculator-java-junit-jupiter/src/test/java/io/cucumber/examples/calculator/RunCucumberTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
import static io.cucumber.junit.platform.engine.Constants.GLUE_PROPERTY_NAME;
99

1010
/**
11-
* Work around. Surefire does not use JUnits Test Engine discovery
12-
* functionality. Alternatively execute the
13-
* org.junit.platform.console.ConsoleLauncher with the maven-antrun-plugin.
11+
* Run Cucumber through the JUnit Platform Suite Engine.
12+
*
13+
* <p>Surefire does not use JUnits Test Engine discovery functionality and can
14+
* only discover class based tests.
1415
*/
1516
@Suite
1617
@IncludeEngines("cucumber")

calculator-kotlin-junit-jupiter/pom.xml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -117,40 +117,6 @@
117117
</properties>
118118
</configuration>
119119
</plugin>
120-
121-
<plugin>
122-
<groupId>org.apache.maven.plugins</groupId>
123-
<artifactId>maven-antrun-plugin</artifactId>
124-
<version>3.2.0</version>
125-
<executions>
126-
<execution>
127-
<!-- Work around. Surefire does not use JUnits Test Engine discovery functionality.
128-
129-
Alternatively use the JUnit Platform Suite Engine.
130-
-->
131-
<id>cli-test</id>
132-
<phase>test</phase>
133-
<goals>
134-
<goal>run</goal>
135-
</goals>
136-
<configuration>
137-
<target unless="maven.test.skip">
138-
<echo message="Running JUnit Platform CLI"/>
139-
<java classname="org.junit.platform.console.ConsoleLauncher" fork="true"
140-
failonerror="true" newenvironment="true" maxmemory="512m"
141-
classpathref="maven.test.classpath">
142-
<arg value="--include-engine"/>
143-
<arg value="cucumber"/>
144-
<arg value="--scan-classpath"/>
145-
<arg value="${project.build.testOutputDirectory}"/>
146-
<arg value="--reports-dir"/>
147-
<arg value="${project.build.directory}/cucumber-reports"/>
148-
</java>
149-
</target>
150-
</configuration>
151-
</execution>
152-
</executions>
153-
</plugin>
154120
</plugins>
155121
</build>
156122

calculator-kotlin-junit-jupiter/src/test/kotlin/io/cucumber/examples/calculator/RunCucumberKotlinTest.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ import org.junit.platform.suite.api.SelectPackages
77
import org.junit.platform.suite.api.ConfigurationParameter
88

99
/**
10-
* Work around. Surefire does not use JUnits Test Engine discovery
11-
* functionality. Alternatively execute the
12-
* org.junit.platform.console.ConsoleLauncher with the maven-antrun-plugin.
10+
* Run Cucumber through the JUnit Platform Suite Engine.
11+
*
12+
* <p>Surefire does not use JUnits Test Engine discovery functionality and can
13+
* only discover class based tests.
1314
*/
1415
@Suite
1516
@IncludeEngines("cucumber")

0 commit comments

Comments
 (0)