refactor: 💡 Convert Manifest to Java Type sooner

This will benefit the Scala3 migration as Manifest won't exist anymore and we will need to convert to Java Type in another way sooner as well

Author: gaeljw

cucumber-scala/src/main/scala/io/cucumber/scala/ScalaStepDefinition.scala

@@ -1,5 +1,6 @@
 package io.cucumber.scala
 
+import java.lang.reflect.{Type => JType}
 import java.util.{List => JList}
 
 import io.cucumber.core.backend.{ParameterInfo, ScenarioScoped, StepDefinition}
@@ -16,9 +17,8 @@ trait ScalaStepDefinition extends StepDefinition with AbstractGlueDefinition {
     stepDetails.types
   )
 
-  private def fromTypes(types: Seq[Manifest[_]]): JList[ParameterInfo] = {
+  private def fromTypes(types: Seq[JType]): JList[ParameterInfo] = {
     types
-      .map(ScalaTypeHelper.asJavaType)
       .map(new ScalaTypeResolver(_))
       .map(new ScalaParameterInfo(_))
       .toList

cucumber-scala/src/main/scala/io/cucumber/scala/ScalaStepDetails.scala

@@ -1,5 +1,7 @@
 package io.cucumber.scala
 
+import java.lang.reflect.{Type => JType}
+
 /** Implementation of step definition for scala.
   *
   * @param frame   Representation of a stack frame containing information about the context in which a
@@ -13,6 +15,6 @@ case class ScalaStepDetails(
     frame: StackTraceElement,
     name: String,
     pattern: String,
-    types: Seq[Manifest[_]],
+    types: Seq[JType],
     body: List[Any] => Any
 )

cucumber-scala/src/main/scala/io/cucumber/scala/StepDsl.scala

@@ -1532,8 +1532,9 @@ private[scala] trait StepDsl extends BaseScalaDsl {
     private def register(
         manifests: Manifest[_ <: Any]*
     )(pf: PartialFunction[List[Any], Any]): Unit = {
+      val types = manifests.map(ScalaTypeHelper.asJavaType)
       registry.registerStep(
-        ScalaStepDetails(Utils.frame(self), name, regex, manifests, pf)
+        ScalaStepDetails(Utils.frame(self), name, regex, types, pf)
       )
     }