Implement HookDefinition.getHookType and unimplement Location.getLocation

[mpkorstanje]

🤔 What's the problem you're trying to solve?

I'm re-implementing the json-formatter to use messages. And as part of that I'm running regression tests with cucumber-jvm 7.26.0 and cucumber-scala 8.29.0.

Currently HookDefinition.getHookType is not implemented. As a result it is not possible to produce report.json from an equivalent message stream in report.ndjson.

Additionally this Location.getLocation implementation is giving me some problems:

cucumber-jvm-scala/cucumber-scala/src/main/scala/io/cucumber/scala/ScalaStepDefinition.scala

Lines 38 to 40 in a528111

	// Easier to just print out fileName and lineNumber
	override def getLocation(): String =
	stepDetails.frame.getFileName + ":" + stepDetails.frame.getLineNumber

The message protocol includes the source reference rather than the location string. And because the source reference in this case is based off a stacktrace element, I can't reproduce the location string as Cucumber Scala produces it, because the Cucumber Java8 backend uses StackTraceElement.toString() and I can't tell from the messages which backend is used.

Removing the implementation would help me out as the expected implementation is already used here:

cucumber-jvm-scala/cucumber-scala/src/main/scala/io/cucumber/scala/AbstractGlueDefinition.scala

Lines 21 to 23 in a528111

	override def getLocation(): String = {
	location.toString
	}

✨ What's your proposed solution?

n/a

⛏ Have you considered any alternatives or workarounds?

For the regression tests I can probably grep around the results of Location.getLocation. But I can't do without HookDefinition.getHookType.

📚 Any additional context?

Regression tests for Scala are added here cucumber/cucumber-json-formatter#2

[gaeljw]

I'm not super familiar with this part of the code but I'll look into it!

[gaeljw]

Implementing getHookType was easy and impactless.

Changing the getLocation has some impacts but I don't think this should cause issue to users, it will just add a bit of noise in the output. For instance:

- ScalaDslStepsTest.scala:68
+ io.cucumber.scala.ScalaDslStepsTest$Glue$3.<init>(ScalaDslStepsTest.scala:68)

[gaeljw]

If that sounds right to you, I'll cut the release in the afternoon @mpkorstanje

[gaeljw]

Released in 8.30.0 of Cucumber Scala