All ScalaHookDefinition.location point to same location

[mpkorstanje]

👓 What did you see?

Currently the source reference for all hooks points to io.cucumber.scala.GlueAdaptor.$anonfun$loadRegistry$8 which doesn't seem quite right.

✅ What did you expect to see?

A source reference inside the step definition file.

📦 Which tool/library version are you using?

No response

🔬 How could we reproduce it?

No response

📚 Any additional context?

The current implementation returns the location from the stack trace created here:

cucumber-jvm-scala/cucumber-scala/src/main/scala/io/cucumber/scala/ScalaHookDefinition.scala

Line 13 in 669421a

override val location: StackTraceElement = new Exception().getStackTrace()(3)

But this has the wrong location because hooks are created from ScalaHookDetails in the GlueAdaptor. The ScalaHookDetails.location does seem to be correct. So presumably the fix would be to:

override val location: StackTraceElement = hookDetails.stackTraceElement

[mpkorstanje]

And sorry I didn't spot this earlier. Scala isn't my daily driver. 😅

[mpkorstanje]

At a glance the same problem seems to exist for ScalaDocStringTypeDefinition, ScalaDataTableTypeDefinition, ScalaParameterTypeDefinition, ScalaDefaultParameterTransformerDefinition, ScalaDefaultDataTableCellTransformerDefinition and ScalaDefaultDataTableEntryTransformerDefinition.

[gaeljw]

No worries, I'll give it a look in the coming days :)