Remove the use of the maven-toolchains-plugin (#2595)

To benefit from GitHubs release automation[1] Cucumber should be able to be
build on an arbitrary jdk docker image. Typically, these do not provide Maven
tool chain configurations.

Instead of going through the effort of setting this up in the
cucumber/action-publish-mvn we can forge the use of toolchains, simplifying
the build process somewhat.

To ensure Cucumber is not build with a JDK version less than 11, the enforcer
plugin will check this now.

Additionally:
 - Allow spotless and revapi to work in sub modules
 - Use surefire and failsafe 3.0.0-M7 everywhere
 - Fix example parent pom versions

1: https://github.com/cucumber/action-publish-mvn

Author: mpkorstanje

.github/workflows/.toolchains.xml

@@ -31,9 +31,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true -B --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true -B --show-version
       - name: Test
-        run: mvn verify --toolchains .github/workflows/.toolchains.xml
+        run: mvn verify
         env:
           CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
 
@@ -54,9 +54,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Javadoc
-        run: mvn javadoc:jar --toolchains .github/workflows/.toolchains.xml
+        run: mvn javadoc:jar
 
   coverage:
     name: 'Coverage'
@@ -75,9 +75,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Test (Coverage)
-        run: mvn jacoco:prepare-agent verify jacoco:report --toolchains .github/workflows/.toolchains.xml
+        run: mvn jacoco:prepare-agent verify jacoco:report
       - uses: codecov/codecov-action@v3
         with:
           fail_ci_if_error: true
@@ -101,6 +101,6 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Test (Semver check)
-        run: mvn verify -Pcheck-semantic-version -DskipTests=true -DskipITs=true -Darchetype.test.skip=true --toolchains .github/workflows/.toolchains.xml
+        run: mvn verify -Pcheck-semantic-version -DskipTests=true -DskipITs=true -Darchetype.test.skip=true

.github/workflows/build.yml

@@ -12,10 +12,10 @@ We appreciate that. Do keep the following in mind:
 
 ## Formatting Java
 
-To automatically format the java source code run
+The source code is formatted automatically by spotless when running:
 
 ```
-mvn initialize spotless:apply
+mvn install
 ```
 
 To configure Intelij IDEA/Eclipse use the configuration files in `.spotless/`.

CONTRIBUTING.md

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-cli</artifactId>

examples/calculator-java-cli/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-junit4</artifactId>

examples/calculator-java-junit4/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-junit5</artifactId>

examples/calculator-java-junit5/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-testng</artifactId>

examples/calculator-java-testng/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java8-cli</artifactId>

examples/calculator-java8-cli/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-jvm</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>cucumber-examples</artifactId>

examples/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>spring-java-junit5</artifactId>