[Build] Disable spotless apply in ci (#2519)

Spotless reformats the code to the default when building locally. This should
not run in CI. Then we can't check if the code was properly formatted.

Additionally CI should only run each job once rather then once for a push
or for a merge request.

Author: mpkorstanje

.github/workflows/build.yml

@@ -1,8 +1,10 @@
 name: Cucumber CI
 
 on:
-  push:
   pull_request:
+    branches:
+      - '**'
+  push:
     branches:
       - main
       - v4.x.x
@@ -30,7 +32,7 @@ jobs:
       - name: Install dependencies
         run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true -B --show-version --toolchains .github/workflows/.toolchains.xml
       - name: Test
-        run: mvn verify -P-spotless-apply --toolchains .github/workflows/.toolchains.xml
+        run: mvn verify --toolchains .github/workflows/.toolchains.xml
         env:
           CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
 

pom.xml

@@ -82,7 +82,9 @@
         <profile>
             <id>spotless-apply</id>
             <activation>
-                <activeByDefault>true</activeByDefault>
+                <property>
+                    <name>!CI</name>
+                </property>
             </activation>
             <build>
                 <pluginManagement>