File tree Expand file tree Collapse file tree 3 files changed +9
-2
lines changed
cucumber-picocontainer/src
main/java/io/cucumber/picocontainer
test/java/io/cucumber/picocontainer Expand file tree Collapse file tree 3 files changed +9
-2
lines changed Original file line number Diff line number Diff line change @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
14
14
- [ Core] Fixed ` cucumber.publish.enabled=false ` ([ #2747 ] ( https://github.com/cucumber/cucumber-jvm/pull/2747 ) M.P. Korstanje)
15
15
- [ JUnit Platform Engine] Fixed ` cucumber.publish.enabled=false ` ([ #2747 ] ( https://github.com/cucumber/cucumber-jvm/pull/2747 ) M.P. Korstanje)
16
16
- [ Java] Fixed duplicate step definition for classes with interfaces ([ #2757 ] ( https://github.com/cucumber/cucumber-jvm/issues/2757 ) Julien Kronegg)
17
+ - [ Pico] Fixed unsatisfiable dependency with disposables ([ #2762 ] ( https://github.com/cucumber/cucumber-jvm/issues/2762 ) Julien Kronegg)
17
18
18
19
## [ 7.12.0] - 2023-04-29
19
20
### Added
Original file line number Diff line number Diff line change @@ -43,8 +43,8 @@ public void stop() {
43
43
@ Override
44
44
public boolean addClass (Class <?> clazz ) {
45
45
if (isInstantiable (clazz ) && classes .add (clazz )) {
46
- pico .addComponent (clazz );
47
46
addConstructorDependencies (clazz );
47
+ pico .addComponent (clazz );
48
48
}
49
49
return true ;
50
50
}
Original file line number Diff line number Diff line change 1
1
package io .cucumber .picocontainer ;
2
2
3
+ import org .picocontainer .Disposable ;
4
+
3
5
public class StepDefinitionsWithTransitiveDependencies {
4
6
5
7
final FirstDependency firstDependency ;
@@ -8,12 +10,16 @@ public StepDefinitionsWithTransitiveDependencies(FirstDependency firstDependency
8
10
this .firstDependency = firstDependency ;
9
11
}
10
12
11
- public static class FirstDependency {
13
+ public static class FirstDependency implements Disposable {
12
14
final SecondDependency secondDependency ;
13
15
14
16
public FirstDependency (SecondDependency secondDependency ) {
15
17
this .secondDependency = secondDependency ;
16
18
}
19
+
20
+ @ Override
21
+ public void dispose () {
22
+ }
17
23
}
18
24
19
25
public static class SecondDependency {
You can’t perform that action at this time.
0 commit comments