[Core] Fix incomplete id for scenarios under rules in json output (#3026)

When rules were added, the TestSourcesModel was not updated to account
for these. As a result, the id for a given scenario was incomplete.

Also improved performance a tiny bit by reusing a pre-build regular
expression.

Author: mpkorstanje

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - [JUnit Platform Engine] Don't use Java 9+ APIs ([#3025](https://github.com/cucumber/cucumber-jvm/pull/3025) M.P. Korstanje)
 - [JUnit Platform Engine] Implement toString on custom DiscoverySelectors
+  [Core] Fix incomplete id for scenarios under rules in json output ([#3026](https://github.com/cucumber/cucumber-jvm/pull/3026) M.P. Korstanje)
 
 ## [7.25.0] - 2025-07-10
 ### Changed

cucumber-core/src/main/java/io/cucumber/core/plugin/TestSourcesModel.java

@@ -7,6 +7,7 @@
 import io.cucumber.messages.types.Feature;
 import io.cucumber.messages.types.FeatureChild;
 import io.cucumber.messages.types.GherkinDocument;
+import io.cucumber.messages.types.Rule;
 import io.cucumber.messages.types.RuleChild;
 import io.cucumber.messages.types.Scenario;
 import io.cucumber.messages.types.Source;
@@ -21,6 +22,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Optional;
+import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
 final class TestSourcesModel {
@@ -43,6 +45,9 @@ static boolean isBackgroundStep(AstNode astNode) {
 
     static String calculateId(AstNode astNode) {
         Object node = astNode.node;
+        if (node instanceof Rule) {
+            return calculateId(astNode.parent) + ";" + convertToId(((Rule) node).getName());
+        }
         if (node instanceof Scenario) {
             return calculateId(astNode.parent) + ";" + convertToId(((Scenario) node).getName());
         }
@@ -61,8 +66,10 @@ static String calculateId(AstNode astNode) {
         return "";
     }
 
+    private static final Pattern replacementPattern = Pattern.compile("[\\s'_,!]");
+
     static String convertToId(String name) {
-        return name.replaceAll("[\\s'_,!]", "-").toLowerCase();
+        return replacementPattern.matcher(name).replaceAll("-").toLowerCase();
     }
 
     static URI relativize(URI uri) {

cucumber-core/src/test/java/io/cucumber/core/plugin/JsonFormatterTest.java

@@ -305,7 +305,7 @@ void should_format_scenario_with_a_rule() throws JSONException {
                 "        \"line\": 4,\n" +
                 "        \"name\": \"Monkey eats bananas\",\n" +
                 "        \"description\": \"\",\n" +
-                "        \"id\": \";monkey-eats-bananas\",\n" +
+                "        \"id\": \"banana-party;this-is-all-monkey-business;monkey-eats-bananas\",\n" +
                 "        \"type\": \"scenario\",\n" +
                 "        \"keyword\": \"Scenario\",\n" +
                 "        \"steps\": [\n" +
@@ -405,7 +405,7 @@ void should_format_scenario_with_a_rule_and_background() throws JSONException {
                 "        \"line\": 11,\n" +
                 "        \"name\": \"Monkey eats bananas\",\n" +
                 "        \"description\": \"\",\n" +
-                "        \"id\": \";monkey-eats-bananas\",\n" +
+                "        \"id\": \"banana-party;this-is-all-monkey-business;monkey-eats-bananas\",\n" +
                 "        \"type\": \"scenario\",\n" +
                 "        \"keyword\": \"Scenario\",\n" +
                 "        \"steps\": [\n" +