Skip to content

Commit f507c4c

Browse files
committed
[Core] Disable publish plugin banner
Without the significant sponsor cost incurring components such as hosting online reports is very uncertain[1]. As such we should not confront new users with this banner. 1. https://mattwynne.net/new-beginning
1 parent 8f11a19 commit f507c4c

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

cucumber-core/src/main/java/io/cucumber/core/options/RuntimeOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public final class RuntimeOptions implements
5353
private Class<? extends UuidGenerator> uuidGeneratorClass;
5454
private String publishToken;
5555
private boolean publish;
56-
private boolean publishQuiet;
56+
private boolean publishQuiet = true;
5757
private boolean enablePublishPlugin;
5858

5959
private RuntimeOptions() {

cucumber-core/src/test/java/io/cucumber/core/options/CucumberOptionsAnnotationParserTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import io.cucumber.core.eventbus.UuidGenerator;
66
import io.cucumber.core.exception.CucumberException;
77
import io.cucumber.core.plugin.HtmlFormatter;
8-
import io.cucumber.core.plugin.NoPublishFormatter;
98
import io.cucumber.core.plugin.PluginFactory;
109
import io.cucumber.core.plugin.Plugins;
1110
import io.cucumber.core.plugin.PrettyFormatter;
@@ -169,13 +168,12 @@ void should_set_publish_when_true() {
169168
}
170169

171170
@Test
172-
void should_set_no_publish_formatter_when_plugin_option_false() {
171+
void should_not_set_no_publish_formatter_when_plugin_option_false() {
173172
RuntimeOptions runtimeOptions = parser()
174173
.parse(WithoutOptions.class)
175174
.enablePublishPlugin()
176175
.build();
177-
assertThat(runtimeOptions.plugins(), hasSize(1));
178-
assertThat(runtimeOptions.plugins().get(0).pluginClass(), equalTo(NoPublishFormatter.class));
176+
assertThat(runtimeOptions.plugins(), empty());
179177
}
180178

181179
@Test

cucumber-core/src/test/java/io/cucumber/core/options/CucumberPropertiesParserTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,12 @@ void should_parse_plugin() {
160160
}
161161

162162
@Test
163-
void should_have_no_publish_plugin_enabled_by_default() {
163+
void should_have_publish_plugin_disabled_by_default() {
164164
RuntimeOptions options = cucumberPropertiesParser
165165
.parse(properties)
166166
.enablePublishPlugin()
167167
.build();
168-
assertThat(options.plugins().get(0).pluginString(), equalTo("io.cucumber.core.plugin.NoPublishFormatter"));
168+
assertThat(options.plugins(), empty());
169169
}
170170

171171
@Test

0 commit comments

Comments
 (0)