Minimal test coverage

Author: mpkorstanje

cucumber-core/src/main/java/io/cucumber/core/plugin/DefaultSummaryPrinter.java

@@ -66,26 +66,26 @@ public DefaultSummaryPrinter() {
 
     @Override
     public void setEventPublisher(EventPublisher publisher) {
-        publisher.registerHandlerFor(Envelope.class, repository::update);
-        publisher.registerHandlerFor(TestRunFinished.class, event -> print());
+        publisher.registerHandlerFor(Envelope.class, envelope -> {
+            repository.update(envelope);
+            envelope.getTestRunFinished().ifPresent(testRunFinished -> print());
+        });
     }
 
     private void print() {
         out.println();
         printStats();
         printErrors();
         printSnippets();
-        out.println();
     }
 
     private void printStats() {
         printNonPassingScenarios();
         printScenarioCounts();
         printStepCounts();
         printDuration();
-        out.println();
     }
-    
+
     private void printNonPassingScenarios() {
         Map<TestStepResultStatus, List<TestCaseFinished>> testCaseFinishedByStatus = query
                 .findAllTestCaseFinished()
@@ -109,15 +109,16 @@ private void printScenarios(
         }
         for (TestCaseFinished testCaseFinished : scenarios) {
             query.findPickleBy(testCaseFinished).ifPresent(pickle -> {
-                String location = pickle.getUri() + query.findLocationOf(pickle).map(Location::getLine).map(line -> ":" + line).orElse("");
+                String location = pickle.getUri()
+                        + query.findLocationOf(pickle).map(Location::getLine).map(line -> ":" + line).orElse("");
                 out.println(location + " # " + pickle.getName());
             });
         }
         if (!scenarios.isEmpty()) {
             out.println();
         }
     }
-    
+
     private void printScenarioCounts() {
         List<TestCaseFinished> allTestCaseFinished = query.findAllTestCaseFinished();
         if (allTestCaseFinished.isEmpty()) {
@@ -134,14 +135,13 @@ private void printScenarioCounts() {
         out.println(")");
     }
 
-
     private void printStepCounts() {
         List<TestStepFinished> testStepsFinished = query.findAllTestStepFinished();
         if (testStepsFinished.isEmpty()) {
             out.println("0 Steps");
             return;
         }
-        
+
         Map<TestStepResultStatus, Long> testStepResultStatus = testStepsFinished.stream()
                 .collect(countTestStepResultStatusByTestStepFinished());
 
@@ -229,14 +229,14 @@ private void printSnippets() {
     private Collector<TestCaseFinished, ?, Map<TestStepResultStatus, Long>> countTestStepResultStatusByTestCaseFinished() {
         return groupingBy(this::getTestStepResultStatusBy, counting());
     }
-    
+
     private TestStepResultStatus getTestStepResultStatusBy(TestCaseFinished testCaseFinished) {
         return query.findMostSevereTestStepResultBy(testCaseFinished)
                 .map(TestStepResult::getStatus)
                 // By definition
                 .orElse(TestStepResultStatus.PASSED);
     }
-    
+
     private static Collector<TestStepFinished, ?, Map<TestStepResultStatus, Long>> countTestStepResultStatusByTestStepFinished() {
         return groupingBy(DefaultSummaryPrinter::getTestStepResultStatusBy, counting());
     }

cucumber-core/src/test/java/io/cucumber/core/plugin/DefaultSummaryPrinterTest.java

@@ -1,74 +1,58 @@
 package io.cucumber.core.plugin;
 
-import io.cucumber.core.eventbus.EventBus;
+import io.cucumber.core.backend.StubStepDefinition;
+import io.cucumber.core.feature.TestFeatureParser;
+import io.cucumber.core.gherkin.Feature;
+import io.cucumber.core.options.RuntimeOptionsBuilder;
+import io.cucumber.core.runner.StepDurationTimeService;
+import io.cucumber.core.runtime.Runtime;
+import io.cucumber.core.runtime.StubBackendSupplier;
+import io.cucumber.core.runtime.StubFeatureSupplier;
 import io.cucumber.core.runtime.TimeServiceEventBus;
-import io.cucumber.plugin.event.Location;
-import io.cucumber.plugin.event.Result;
-import io.cucumber.plugin.event.SnippetsSuggestedEvent;
-import io.cucumber.plugin.event.SnippetsSuggestedEvent.Suggestion;
-import io.cucumber.plugin.event.Status;
-import io.cucumber.plugin.event.TestRunFinished;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.ByteArrayOutputStream;
-import java.net.URI;
-import java.time.Clock;
 import java.time.Duration;
-import java.time.ZoneId;
 import java.util.Locale;
 import java.util.UUID;
 
+import static io.cucumber.core.plugin.Bytes.bytes;
 import static io.cucumber.core.plugin.IsEqualCompressingLineSeparators.equalCompressingLineSeparators;
-import static java.nio.charset.StandardCharsets.UTF_8;
-import static java.time.Instant.ofEpochSecond;
-import static java.util.Collections.singletonList;
+import static io.cucumber.core.plugin.PrettyFormatterStepDefinition.oneReference;
+import static io.cucumber.core.plugin.PrettyFormatterStepDefinition.threeReference;
+import static io.cucumber.core.plugin.PrettyFormatterStepDefinition.twoReference;
 import static org.hamcrest.MatcherAssert.assertThat;
 
 class DefaultSummaryPrinterTest {
 
-    private final ByteArrayOutputStream out = new ByteArrayOutputStream();
-    private final DefaultSummaryPrinter summaryPrinter = new DefaultSummaryPrinter(out, Locale.US);
-    private final EventBus bus = new TimeServiceEventBus(
-        Clock.fixed(ofEpochSecond(0), ZoneId.of("UTC")),
-        UUID::randomUUID);
-
-    @BeforeEach
-    void setup() {
-        summaryPrinter.setEventPublisher(bus);
-    }
-
     @Test
-    void does_not_print_duplicate_snippets() {
-        bus.send(new SnippetsSuggestedEvent(
-            bus.getInstant(),
-            URI.create("classpath:com/example.feature"),
-            new Location(12, -1),
-            new Location(13, -1),
-            new Suggestion("", singletonList("snippet"))));
-
-        bus.send(new SnippetsSuggestedEvent(
-            bus.getInstant(),
-            URI.create("classpath:com/example.feature"),
-            new Location(12, -1),
-            new Location(14, -1),
-            new Suggestion("", singletonList("snippet"))));
-
-        bus.send(new TestRunFinished(bus.getInstant(), new Result(Status.PASSED, Duration.ZERO, null)));
-
-        assertThat(new String(out.toByteArray(), UTF_8), equalCompressingLineSeparators("" +
+    void writesSummary() {
+        Feature feature = TestFeatureParser.parse("path/test.feature", "" +
+                "Feature: feature name\n" +
+                "  Scenario: scenario name\n" +
+                "    Given first step\n" +
+                "    When second step\n" +
+                "    Then third step\n");
+
+        StepDurationTimeService timeService = new StepDurationTimeService(Duration.ofMillis(1128));
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        Runtime.builder()
+                .withEventBus(new TimeServiceEventBus(timeService, UUID::randomUUID))
+                .withFeatureSupplier(new StubFeatureSupplier(feature))
+                .withAdditionalPlugins(timeService, new DefaultSummaryPrinter(out, Locale.US))
+                .withRuntimeOptions(new RuntimeOptionsBuilder().setMonochrome().build())
+                .withBackendSupplier(new StubBackendSupplier(
+                    new StubStepDefinition("first step", oneReference()),
+                    new StubStepDefinition("second step", twoReference()),
+                    new StubStepDefinition("third step", threeReference())))
+                .build()
+                .run();
+
+        assertThat(out, bytes(equalCompressingLineSeparators("" +
                 "\n" +
-                "0 Scenarios\n" +
-                "0 Steps\n" +
-                "0m0.000s\n" +
-                "\n" +
-                "\n" +
-                "You can implement missing steps with the snippets below:\n" +
-                "\n" +
-                "snippet\n" +
-                "\n" +
-                "\n"));
-
+                "1 Scenarios (1 passed)\n" +
+                "3 Steps (3 passed)\n" +
+                "0m3.384s\n")));
     }
 
 }