Skip to content

[Java8] Deprecate cucumber-java8 #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Java8] Deprecate cucumber-java8 #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- The `progress` formatter is no longer enabled by default on CLI. Use `--plugin progress` to enable.

### Deprecated
* [Java8] Deprecated `cucumber-java8` ([#2174](https://github.com/cucumber/cucumber-jvm/issues/2174) M.P. Korstanje)
- For details please see:
* https://github.com/cucumber/cucumber-jvm/issues/2174
* https://github.com/cucumber/cucumber-jvm/issues/1817
* https://github.com/jhalterman/typetools/issues/52

### Removed
* [Core] Removed `--strict` and `--no-strict` options ([#1788](https://github.com/cucumber/cucumber-jvm/issues/1788) M.P. Korstanje)
Expand Down
2 changes: 1 addition & 1 deletion java8/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<artifactId>cucumber-java8</artifactId>
<packaging>jar</packaging>
<name>Cucumber-JVM: Java 8</name>
<name>Cucumber-JVM: Java 8 - Deprecated</name>

<properties>
<project.Automatic-Module-Name>io.cucumber.java8</project.Automatic-Module-Name>
Expand Down
10 changes: 10 additions & 0 deletions java8/src/main/java/io/cucumber/java8/Java8BackendProviderService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,23 @@
import io.cucumber.core.backend.BackendProviderService;
import io.cucumber.core.backend.Container;
import io.cucumber.core.backend.Lookup;
import io.cucumber.core.logging.Logger;
import io.cucumber.core.logging.LoggerFactory;

import java.util.function.Supplier;

public final class Java8BackendProviderService implements BackendProviderService {

private static final Logger log = LoggerFactory.getLogger(Java8BackendProviderService.class);

@Override
public Backend create(Lookup lookup, Container container, Supplier<ClassLoader> classLoaderProvider) {
log.warn(() -> "" +
"cucumber-java8 is deprecated. For details please see:\n" +
" * https://github.com/cucumber/cucumber-jvm/issues/2174" +
" * https://github.com/cucumber/cucumber-jvm/issues/1817" +
" * https://github.com/jhalterman/typetools/issues/52");

return new Java8Backend(lookup, container, classLoaderProvider);
}

Expand Down