Feature/upgrade ci (#1722)

* Tidy up of all workflow CI actions / test inputs

* Linting fixes

* move doc images to docs folder

Author: luke-hill

.github/PULL_REQUEST_TEMPLATE.md

@@ -16,21 +16,10 @@ Please delete options that are not relevant.
 - Breaking change (will cause existing functionality to not
   work as expected)
 - This change requires an update of [cucumber.io/docs](https://cucumber.io/docs)
+- If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.
 
 Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
 
-## Note to other contributors
-
-If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.
-
-## Update required of cucumber.io/docs
-
-If the [Cucumber documentation](https://cucumber.io/docs/) requires an update,
-submit a PR to [cucumber/docs](https://github.com/cucumber/docs/) and
-reference it here.
-
-e.g. "Ref: cucumber/docs/pull/#99"
-
 # Checklist:
 
 Your PR is ready for review once the following checklist is

.github/actions/test-ruby/action.yml

@@ -8,14 +8,12 @@ inputs:
 
 runs:
   using: "composite"
-
   steps:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
-
     - name: Run tests
       run: bundle exec rake
       shell: bash

.github/lock.yml

@@ -19,16 +19,10 @@ lockComment: >
 setLockReason: true
 
 # Limit to only `issues` or `pulls`
-# only: issues
+only: issues
 
 # Optionally, specify configuration settings just for `issues` or `pulls`
 # issues:
 #   exemptLabels:
 #     - help-wanted
 #   lockLabel: outdated
-
-# pulls:
-#   daysUntilLock: 30
-
-# Repository to extend settings from
-# _extends: repo

.github/workflows/cucumber-ruby.yml

@@ -26,7 +26,6 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
-
       - name: Run ruby tests
         uses: ./.github/actions/test-ruby
         with:

.github/workflows/release.yml

@@ -12,7 +12,6 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-
       - name: Check commit has been pushed on origin/main
         run: |
           git fetch --quiet origin main
@@ -30,7 +29,6 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
-
       - name: Run ruby tests
         uses: ./.github/actions/test-ruby
         with:
@@ -44,7 +42,6 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-
       - name: Publish ruby gem
         uses: cucumber/[email protected]
         with:

.github/workflows/rubocop.yml

@@ -20,6 +20,6 @@ jobs:
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
-          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+          bundler-cache: true
       - name: Run tests
         run: bundle exec rake rubocop

README.md

@@ -1,6 +1,4 @@
-<p align="center">
-  <img src="./.github/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by Smartbear" width="428" />
-</p>
+<img src="docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by Smartbear" width="428" />
 
 # Cucumber
 
@@ -18,9 +16,7 @@ written in plain language, they can be read by anyone on your team. Because they
 read by anyone, you can use them to help improve communication, collaboration and trust on
 your team.
 
-<p align="center">
-  <img src="./.github/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" />
-</p>
+<img src="docs/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" />
 
 This is the Ruby implementation of Cucumber. Cucumber is also available for [JavaScript](https://github.com/cucumber/cucumber-js),
 [Java](https://github.com/cucumber/cucumber-jvm), and a lot of other languages. You can find a list of implementations here: https://cucumber.io/docs/installation/.