Skip to content

Commit 075fcb7

Browse files
authored
Refactor/tidy up workflows (#1730)
* Tidy up rubocop workflow * Tidy up release workflow * Tidy up cucumber-ruby workflow
1 parent d6b749d commit 075fcb7

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed

.github/workflows/cucumber-ruby.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@ jobs:
2222
ruby: jruby-9.4
2323
- os: ubuntu-latest
2424
ruby: truffleruby-head
25-
2625
runs-on: ${{ matrix.os }}
2726
steps:
2827
- uses: actions/checkout@v3
29-
- name: Run ruby tests
30-
uses: ./.github/actions/test-ruby
28+
- uses: ./.github/actions/test-ruby
3129
with:
3230
ruby-version: ${{ matrix.ruby }}

.github/workflows/release.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@ jobs:
99
pre-release-check:
1010
name: Perform checks before releasing
1111
runs-on: ubuntu-latest
12-
1312
steps:
1413
- uses: actions/checkout@v3
15-
- name: Check commit has been pushed on origin/main
16-
run: |
14+
- run: |
1715
git fetch --quiet origin main
1816
git merge-base --is-ancestor HEAD origin/main
1917
@@ -25,12 +23,10 @@ jobs:
2523
include:
2624
- os: ubuntu-latest
2725
ruby: jruby-9.4
28-
2926
runs-on: ${{ matrix.os }}
3027
steps:
3128
- uses: actions/checkout@v3
32-
- name: Run ruby tests
33-
uses: ./.github/actions/test-ruby
29+
- uses: ./.github/actions/test-ruby
3430
with:
3531
ruby-version: ${{ matrix.ruby }}
3632

@@ -39,11 +35,9 @@ jobs:
3935
needs: [pre-release-check, tests]
4036
runs-on: ubuntu-latest
4137
environment: Release
42-
4338
steps:
4439
- uses: actions/checkout@v3
45-
- name: Publish ruby gem
46-
uses: cucumber/[email protected]
40+
- uses: cucumber/[email protected]
4741
with:
4842
rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
4943

@@ -54,7 +48,6 @@ jobs:
5448
environment: Release
5549
permissions:
5650
contents: write
57-
5851
steps:
5952
- uses: actions/checkout@v3
6053
- uses: cucumber/[email protected]

.github/workflows/rubocop.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,10 @@ on:
1111
jobs:
1212
rubocop:
1313
runs-on: ubuntu-latest
14-
strategy:
15-
matrix:
16-
ruby-version: ["3.2"]
1714
steps:
1815
- uses: actions/checkout@v3
19-
- name: Set up Ruby
20-
uses: ruby/setup-ruby@v1
16+
- uses: ruby/setup-ruby@v1
2117
with:
22-
ruby-version: ${{ matrix.ruby-version }}
18+
ruby-version: 3.2
2319
bundler-cache: true
24-
- name: Run tests
25-
run: bundle exec rake rubocop
20+
- run: bundle exec rake rubocop

0 commit comments

Comments
 (0)