Refactor/remove misc files (#1721)

* Remove unused files

* Remove files that can be used in a better way

* Remove flog and instead use verbose loggers

* Move references to new folder structure for upgrade hints

* Fix changelog refs

* Remove changelog script. Tweak gemspec script to only update regular gems and not bundler

* Remove invite collaborator script. We use commit-bit auto-gen and release maintainers are strictly controlled

* Octokit is now no longer needed

* Remove release script from makefile

* Add note about removing nokogiri as verbose dependency once we remove jUnit formatter

* Update releasing process to new polyglot method

* Fix up a tiny portion of readme

* Remove useless constant assigns

* Fix up failures move support code to env.rb

* Add new changelog entry

* Re-ordered changelog

Author: luke-hill

.ruby-gemset

@@ -9,6 +9,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
 Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) for more info on how to contribute to Cucumber.
 
 ## [Unreleased]
+### Removed
+- Removed a whole bunch of miscellaneous script files that are no longer used (Either in development or usage) ([#1721](https://github.com/cucumber/cucumber-ruby/pull/1721) [luke-hill](https://github.com/luke-hill))
+
 ### Changed
 - Began to tidy up (Cleared some AutoFix cops), and organise rubocop tech-debt in repo (This introduced new rubocop sub-gems) ([#1716](https://github.com/cucumber/cucumber-ruby/pull/1716) [luke-hill](https://github.com/luke-hill))
 
@@ -24,6 +27,9 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 - Cucumber was unable to generate the correct `VERSION` constant ([#1729](https://github.com/cucumber/cucumber-ruby/pull/1729) [luke-hill](https://github.com/luke-hill))
 
 ## [9.0.0] - 2023-08-31
+### Removed
+- Removed support for Ruby 2.6 and JRuby 9.3 ([#1699](https://github.com/cucumber/cucumber-ruby/pull/1699))
+
 ### Added
 - Add option `--retry-total` ([#1669](https://github.com/cucumber/cucumber-ruby/pull/1669))
 
@@ -36,9 +42,6 @@ with [mini_mime](https://rubygems.org/gems/mini_mime)
 ### Fixed
 - Cucumber may raise NoMethodError when CUCUMBER_COLORS environment was set ([#1641](https://github.com/cucumber/cucumber-ruby/pull/1641/) [s2k](https://github.com/s2k))
 
-### Removed
-- Removed support for Ruby 2.6 and JRuby 9.3 ([#1699](https://github.com/cucumber/cucumber-ruby/pull/1699))
-
 ## [8.0.0] - 2022-05-19
 ### Added
 - Add a _WARNING_ message when using a space-separated string with cucumber_opts
@@ -57,13 +60,30 @@ with [mini_mime](https://rubygems.org/gems/mini_mime)
 - Suppress RSspec deprecation warnings([#1631](https://github.com/cucumber/cucumber-ruby/pull/1631))
 
 ## [8.0.0.RC.1] - 2022-01-19
+### Removed
+- `AfterConfiguration` has been removed. Please use `InstallPlugin` or `BeforeAll` instead.
+  See upgrading notes for [8.0.0.md](upgrading_notes/8.0.0.md#upgrading-to-800) to update your code accordingly.
+  ([#1591](https://github.com/cucumber/cucumber-ruby/pull/1591))
+- The built-in Wire protocol
+  The Wire protocol is still officially supported, but as an optional plugin rather
+  than a built-in feature. See upgrading notes for [8.0.0.md](upgrading_notes/8.0.0.md#upgrading-to-800) to update your code accordingly.
+- Removed former unused `stdin` argument from `Cli::Main`. That may impact your code
+  if you use cucumber API `Cucumber::Cli::Main`. See upgrading notes for [8.0.0.md](upgrading_notes/8.0.0.md#upgrading-to-800).
+  ([#1588](https://github.com/cucumber/cucumber-ruby/pull/1588))
+- Removed `DataTable#map_column!` and `DataTable#map_headers!`.
+  Those methods were error-prone and planned to be removed a long time ago. You
+  can use the immutable versions instead: `DataTable#map_column` and
+  `DataTable#map_headers`.
+  ([#1590](https://github.com/cucumber/cucumber-ruby/pull/1590))
+- Removed support for Ruby 2.5 and JRuby 9.2.
+
 ### Changed
 - Replace dependency [cucumber-create-meta](https://rubygems.org/gems/cucumber-create-meta)
   with the new [cucumber-ci-environment](https://rubygems.org/gems/cucumber-ci-environment)
   ([#1601](https://github.com/cucumber/cucumber-ruby/pull/1601))
 
 - In `DataTable#map_column`, Changed the `strict` argument into a keyword argument.
-  See [UPGRADING.md](./UPGRADING.md#upgrading-to-800)
+  See upgrading notes for [8.0.0.md](upgrading_notes/8.0.0.md#upgrading-to-800)
   ([#1594](https://github.com/cucumber/cucumber-ruby/pull/1594))
 
 - Added Ruby 3.1 ([#1607](https://github.com/cucumber/cucumber-ruby/pull/1607))
@@ -87,25 +107,6 @@ with [mini_mime](https://rubygems.org/gems/mini_mime)
 - Fixed `DataTable#map_headers` when headers have the same prefix
   ([#1598](https://github.com/cucumber/cucumber-ruby/pull/1598))
 
-### Removed
-- `AfterConfiguration` has been removed. Please use `InstallPlugin` or `BeforeAll` instead.
-  See the [UPGRADING.md](./UPGRADING.md#upgrading-to-800) to update your code accordingly.
-  ([#1591](https://github.com/cucumber/cucumber-ruby/pull/1591))
-- The built-in Wire protocol
-  The Wire protocol is still officially supported, but as an optional plugin rather
-  than a built-in feature. See the
-  [UPGRADING.md](./UPGRADING.md#upgrading-to-800)
-  to update your code accordingly.
-- Removed former unused `stdin` argument from `Cli::Main`. That may impact your code
-  if you use cucumber API `Cucumber::Cli::Main`. See [UPGRADING.md](./UPGRADING.md#upgrading-to-800).
-  ([#1588](https://github.com/cucumber/cucumber-ruby/pull/1588))
-- Removed `DataTable#map_column!` and `DataTable#map_headers!`.
-  Those methods were error-prone and planned to be removed a long time ago. You
-  can use the immutable versions instead: `DataTable#map_column` and
-  `DataTable#map_headers`.
-  ([#1590](https://github.com/cucumber/cucumber-ruby/pull/1590))
-- Removed support for Ruby 2.5 and JRuby 9.2.
-
 [Unreleased]: https://github.com/cucumber/cucumber-ruby/compare/v9.0.1...HEAD
 [9.0.1]: https://github.com/cucumber/cucumber-ruby/compare/v9.0.0...v9.0.1
 [9.0.0]: https://github.com/cucumber/cucumber-ruby/compare/v8.0.0...v9.0.0

.yardopts

@@ -41,22 +41,3 @@ bin/json-formatter: $(MONOREPO_PATH)/json-formatter/go/dist/cucumber-json-format
 clean:
 	rm -rf acceptance/*.json bin/json-formatter
 .PHONY: clean
-
-release:
-	[ -d '../secrets' ]  || git clone keybase://team/cucumberbdd/secrets ../secrets
-	git -C ../secrets pull
-	../secrets/update_permissions
-	docker run \
-		--volume "${shell pwd}":/app \
-		--volume "${shell pwd}/../secrets/import-gpg-key.sh":/home/cukebot/import-gpg-key.sh \
-		--volume "${shell pwd}/../secrets/codesigning.key":/home/cukebot/codesigning.key \
-		--volume "${shell pwd}/../secrets/.ssh":/home/cukebot/.ssh \
-		--volume "${shell pwd}/../secrets/.gem":/home/cukebot/.gem \
-		--volume "${HOME}/.gitconfig":/home/cukebot/.gitconfig \
-		--env CUCUMBER_USE_RELEASED_GEMS=1 \
-		--env-file ../secrets/secrets.list \
-		--user 1000 \
-		--rm \
-		-it cucumber/cucumber-build:latest \
-		bash -c "rm Gemfile.lock && bundle && bundle exec rake && bundle exec rake release"
-.PHONY: release

CHANGELOG.md

@@ -52,8 +52,7 @@ Later in this document, bundler is considered being used so all commands are usi
 - Ruby 3.0
 - Ruby 2.7
 - TruffleRuby 22.0.0+
-- JRuby (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/main/docs/jruby-limitations.md))
-  - 9.4
+- JRuby 9.4+ (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/main/docs/jruby-limitations.md))
 
 ### Ruby on Rails
 
@@ -105,19 +104,20 @@ And a file named `steps.rb` in `features/step_definitions` with:
 ```ruby
 # features/step_definitions/steps.rb
 
-Given("this will pass") do
+Given('this will pass') do
   @this_will_pass = true
 end
 
-Given("this will fail") do
+Given('this will fail') do
   @this_will_pass = false
 end
 
-When("I do an action") do
+When('I do an action') do
+  :no_op
 end
 
 Then("some results should be there") do
-  expect(@this_will_pass)
+  expect(@this_will_pass).to be true
 end
 ```
 
@@ -131,7 +131,7 @@ To execute a single feature file:
 
 To execute a single example, indicates the line of the name of the example:
 
-    $ bundle exec cucumber features/rule.feature:7
+    $ bundle exec cucumber features/rule.feature:5
 
 To summarize the results on the standard output, and writte a HTML report on disk:
 

Makefile

@@ -1,34 +1,11 @@
-# Release process for cucumber-ruby
+See [.github/RELEASING](https://github.com/cucumber/.github/blob/main/RELEASING.md).
 
-## Prerequisites
+## When done ##
 
-To release `cucumber-ruby`, you'll need:
+Update the cucumber-ruby version in the documentation project:
 
-- to be a member of the core-team
-- make
-- docker
+* https://github.com/cucumber/docs.cucumber.io
 
-## cucumber-ruby-core
+The cucumber-ruby version for the docs is specified in the docs [versions.yaml](https://github.com/cucumber/docs.cucumber.io/blob/master/data/versions.yaml)
 
-If internal libraries such as `cucumber-gherkin` needs to be updated, you'll
-need to update and release `cucumber-ruby-core` before releasing `cucumber-ruby`.
-
-## Releasing cucumber-ruby
-
-- Upgrade gems with `scripts/update-gemspec`
-- Bump the version number in `lib/cucumber/version`
-- Update `CHANGELOG.md` with the upcoming version number and create a new `Unreleased` section
-- Remove empty sections from `CHANGELOG.md`
-- Commit the changes using a verified signature
-  ```shell
-  git commit --gpg-sign -am "Release X.Y.Z"
-  git push
-  ```
-- Now release it: push to a dedicated `release/` branch:
-  ```shell
-  git push origin main:release/vX.Y.Z
-  ```
-- Check the release has been successfully pushed to [rubygems](https://rubygems.org/gems/cucumber)
-- Finally, update the `cucumber-ruby` version in the
-  [documentation project](https://cucumber.io/docs/installation/) in
-  [versions.yaml](https://github.com/cucumber/docs/blob/master/data/versions.yaml).
+All done! Hurray!

README.md

@@ -34,6 +34,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'sys-uname', '~> 1.2', '>= 1.2.3'
 
   s.add_development_dependency 'cucumber-compatibility-kit', '~> 10.0'
+  # Only needed whilst we are testing the formatters. Can be removed once we remove tests for those
   s.add_development_dependency 'nokogiri', '~> 1.13', '>= 1.13.6'
   s.add_development_dependency 'pry', '~> 0.14', '>= 0.14.1'
   s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
@@ -48,9 +49,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'test-unit', '~> 3.6', '>= 3.6.1'
   s.add_development_dependency 'webrick', '~> 1.8', '>= 1.8.1'
 
-  # For maintainer scripts
-  s.add_development_dependency 'octokit', '~> 6.0', '>= 6.1.0'
-
   # Needed for rake examples
   s.add_development_dependency 'capybara', '~> 3.39', '>= 3.39.2'
   s.add_development_dependency 'rack-test', '~> 2.1', '>= 2.1.0'

RELEASING.md

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require 'nokogiri'
-
 Given('a directory without standard Cucumber project directory structure') do
   FileUtils.cd('.') do
     FileUtils.rm_rf 'features' if File.directory?('features')

cucumber.gemspec

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-def snake_case(name)
-  name.downcase.gsub(/\W/, '_')
-end
-
 Given('the standard step definitions') do
   write_file(
     'features/step_definitions/steps.rb',

features/lib/step_definitions/cucumber_steps.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require 'cucumber/formatter/ansicolor'
+require 'securerandom'
+require 'nokogiri'
 
 CUCUMBER_FEATURES_PATH = 'features/lib'
 
@@ -57,3 +59,7 @@
 After('@disable_fail_fast') do
   Cucumber.wants_to_quit = false
 end
+
+def snake_case(name)
+  name.downcase.gsub(/\W/, '_')
+end