Refactor/rubocop af part2 (#1737)

* AF (And manual): RSpec/BeEql

* AF: RSpec/DescribedClass

* AF: RSpec/PredicateMatcher

* Partial fix for AF: Style/ModuleAndClassChildren

* AF: Style/FloatDivision

* Manual fix and AF refactor of Style/SafeNavigation

* AF: FrozenMutableConstant

* Partial commit temporary pending rebase

* Regen of todo file post merge conflict fixes

* Manual fixes to poor merge for interceptor_spec

* Add changelog

* Autofix more DescribedClass issues post merge

Author: luke-hill

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-09-06 13:00:58 UTC using RuboCop version 1.56.2.
+# on 2023-09-07 08:42:40 UTC using RuboCop version 1.56.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -41,6 +41,12 @@ Lint/SuppressedException:
   Exclude:
     - 'lib/cucumber/rake/task.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/UselessAssignment:
+  Exclude:
+    - 'spec/cucumber/formatter/interceptor_spec.rb'
+
 # Offense count: 9
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
@@ -64,14 +70,6 @@ RSpec/AnyInstance:
   Exclude:
     - 'spec/cucumber/cli/main_spec.rb'
 
-# Offense count: 5
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEql:
-  Exclude:
-    - 'spec/cucumber/cli/configuration_spec.rb'
-    - 'spec/cucumber/cli/options_spec.rb'
-    - 'spec/cucumber/glue/registry_and_more_spec.rb'
-
 # Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnabledMethods.
@@ -96,12 +94,15 @@ RSpec/DescribeClass:
     - '**/spec/views/**/*'
     - 'spec/cck/cck_spec.rb'
 
-# Offense count: 167
+# Offense count: 18
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
-  Enabled: false
+  Exclude:
+    - 'spec/cucumber/formatter/interceptor_spec.rb'
+    - 'spec/cucumber/multiline_argument/data_table_spec.rb'
+    - 'spec/cucumber/runtime/support_code_spec.rb'
 
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -110,11 +111,27 @@ RSpec/EmptyExampleGroup:
     - 'spec/cucumber/filters/activate_steps_spec.rb'
     - 'spec/cucumber/running_test_case_spec.rb'
 
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/EmptyLineAfterFinalLet:
+  Exclude:
+    - 'spec/cucumber/cli/main_spec.rb'
+    - 'spec/cucumber/configuration_spec.rb'
+    - 'spec/cucumber/hooks_spec.rb'
+
 # Offense count: 150
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 58
 
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
+# DisallowedExamples: works
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/cucumber/multiline_argument/data_table_spec.rb'
+
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/ExpectActual:
@@ -129,18 +146,24 @@ RSpec/ExpectInHook:
     - 'spec/cucumber/multiline_argument/data_table_spec.rb'
     - 'spec/cucumber/runtime/meta_message_builder_spec.rb'
 
-# Offense count: 6
+# Offense count: 9
 RSpec/ExpectOutput:
   Exclude:
     - 'spec/cucumber/formatter/interceptor_spec.rb'
 
-# Offense count: 68
+# Offense count: 71
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, each, example
 RSpec/HookArgument:
   Enabled: false
 
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/HooksBeforeExamples:
+  Exclude:
+    - 'spec/cucumber/formatter/interceptor_spec.rb'
+
 # Offense count: 15
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
@@ -188,6 +211,12 @@ RSpec/MultipleExpectations:
 RSpec/MultipleMemoizedHelpers:
   Max: 15
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/MultipleSubjects:
+  Exclude:
+    - 'spec/cucumber/runtime/support_code_spec.rb'
+
 # Offense count: 46
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
@@ -207,14 +236,10 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Max: 6
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
+# Offense count: 1
+RSpec/OverwritingSetup:
   Exclude:
-    - 'spec/cucumber/hooks_spec.rb'
-    - 'spec/cucumber/running_test_case_spec.rb'
+    - 'spec/cucumber/runtime/support_code_spec.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
@@ -229,9 +254,10 @@ RSpec/RepeatedExample:
     - 'spec/cucumber/formatter/rerun_spec.rb'
     - 'spec/cucumber/world/pending_spec.rb'
 
-# Offense count: 2
+# Offense count: 4
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
+    - 'spec/cucumber/formatter/interceptor_spec.rb'
     - 'spec/cucumber/glue/proto_world_spec.rb'
 
 # Offense count: 31
@@ -251,6 +277,18 @@ RSpec/ReturnFromStub:
     - 'spec/cucumber/formatter/junit_spec.rb'
     - 'spec/cucumber/glue/registry_and_more_spec.rb'
 
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ScatteredLet:
+  Exclude:
+    - 'spec/cucumber/runtime/support_code_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ScatteredSetup:
+  Exclude:
+    - 'spec/cucumber/formatter/interceptor_spec.rb'
+
 # Offense count: 9
 RSpec/StubbedMock:
   Exclude:
@@ -278,14 +316,7 @@ RSpec/VerifiedDoubles:
     - 'spec/cucumber/runtime/support_code_spec.rb'
     - 'spec/cucumber/world/pending_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Rake/Desc:
-  Exclude:
-    - 'gem_tasks/contributors.rake'
-    - 'gem_tasks/environment.rake'
-
-# Offense count: 11
+# Offense count: 7
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -298,38 +329,8 @@ Style/ClassAndModuleChildren:
     - 'lib/autotest/cucumber_rails_rspec2.rb'
     - 'lib/autotest/cucumber_rspec.rb'
     - 'lib/autotest/cucumber_rspec2.rb'
-    - 'spec/cucumber/deprecate_spec.rb'
-    - 'spec/cucumber/formatter/fail_fast_spec.rb'
-    - 'spec/cucumber/formatter/interceptor_spec.rb'
-    - 'spec/cucumber/hooks_spec.rb'
 
 # Offense count: 3
 Style/ClassVars:
   Exclude:
     - 'spec/cucumber/glue/step_definition_spec.rb'
-
-# Offense count: 22
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: left_coerce, right_coerce, single_coerce, fdiv
-Style/FloatDivision:
-  Enabled: false
-
-# Offense count: 5
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/cucumber/cli/options.rb'
-    - 'lib/cucumber/file_specs.rb'
-    - 'lib/cucumber/runtime.rb'
-    - 'lib/cucumber/term/ansicolor.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'lib/cucumber/gherkin/formatter/ansi_escapes.rb'

CHANGELOG.md

@@ -19,6 +19,9 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 - Rubocop update. Massively overhauled the cucumber style / rubocop expectations and began to tackle some long-standing tech-debt ([#1733](https://github.com/cucumber/cucumber-ruby/pull/1733) [luke-hill](https://github.com/luke-hill))
 
+- First couple of passes of tidying up approximately 15% of the autofix cops
+([#1736](https://github.com/cucumber/cucumber-ruby/pull/1736) [#1737](https://github.com/cucumber/cucumber-ruby/pull/1737) [luke-hill](https://github.com/luke-hill))
+
 ## [9.0.1] - 2023-09-01
 ### Changed
 - Update dependency of a few associated cucumber sub-gems ([#1715](https://github.com/cucumber/cucumber-ruby/pull/1715) [luke-hill](https://github.com/luke-hill))

examples/i18n/ca/lib/calculadora.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/cs/lib/calculator.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/de/lib/calculator.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/el/lib/calculator.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/en/lib/calculator.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/eo/lib/calculator.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/es/lib/calculador.rb

@@ -11,6 +11,6 @@ def add
   end
 
   def divide
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end

examples/i18n/et/lib/kalkulaator.rb

@@ -11,6 +11,6 @@ def liida
   end
 
   def jaga
-    @args[0].to_f / @args[1].to_f
+    @args[0].to_f / @args[1]
   end
 end