Refactor/remove multiple expects (#1742)

* For pretty spec remove all multiple expectation cop failures for snippet based tests

* Linting tidy for pretty spec

* Cleanup of file loading tests to ensure that tests only test one thing

* Simplify test for multiple worlds

* Final tweaks to registry and more spec to resolve all specs only having 1 assertion

* Remove all duplicate expectations from meta_message_builder

* Remove nearly all duplicate expect situations from options spec

* Stylistic tweaks to activate steps spec

* Remove double expectation wrappers on essentially allow calls for mocking

* Remove all duplicate expectations from activate_steps spec

* Remove around 30% of multiple expectation offenses

* Partial fix for maximum lets

* Fix up all RSpec/NestedGroups offenses

* Fix up incorrect rubocop fix

* Add in additional note about rubocop fixes

Author: luke-hill

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-10-02 14:25:13 UTC using RuboCop version 1.56.4.
+# on 2023-10-03 13:56:41 UTC using RuboCop version 1.56.4.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -69,6 +69,15 @@ Layout/IndentationWidth:
   Exclude:
     - 'spec/cucumber/formatter/fail_fast_spec.rb'
 
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'spec/cucumber/cli/options_spec.rb'
+
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperator:
@@ -185,7 +194,7 @@ RSpec/EmptyLineAfterFinalLet:
     - 'spec/cucumber/configuration_spec.rb'
     - 'spec/cucumber/hooks_spec.rb'
 
-# Offense count: 100
+# Offense count: 83
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 58
@@ -245,9 +254,9 @@ RSpec/MissingExampleGroupArgument:
     - 'spec/cucumber/formatter/fail_fast_spec.rb'
     - 'spec/cucumber/formatter/rerun_spec.rb'
 
-# Offense count: 87
+# Offense count: 59
 RSpec/MultipleExpectations:
-  Max: 8
+  Max: 3
 
 # Offense count: 38
 # Configuration parameters: AllowSubject.
@@ -325,15 +334,14 @@ RSpec/ScatteredLet:
   Exclude:
     - 'spec/cucumber/runtime/support_code_spec.rb'
 
-# Offense count: 9
+# Offense count: 5
 RSpec/StubbedMock:
   Exclude:
     - 'spec/cucumber/cli/configuration_spec.rb'
     - 'spec/cucumber/formatter/interceptor_spec.rb'
-    - 'spec/cucumber/glue/registry_and_more_spec.rb'
     - 'spec/cucumber/runtime/meta_message_builder_spec.rb'
 
-# Offense count: 54
+# Offense count: 57
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
@@ -371,6 +379,12 @@ Style/ClassVars:
   Exclude:
     - 'spec/cucumber/glue/step_definition_spec.rb'
 
+# Offense count: 4
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Exclude:
+    - 'spec/cucumber/cli/options_spec.rb'
+
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 Style/StderrPuts:
@@ -382,10 +396,11 @@ Style/StderrPuts:
     - 'lib/cucumber/rake/task.rb'
     - 'spec/cucumber/formatter/interceptor_spec.rb'
 
-# Offense count: 1
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
     - 'spec/cucumber/cli/options_spec.rb'
+    - 'spec/cucumber/formatter/pretty_spec.rb'

CHANGELOG.md

@@ -11,7 +11,7 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 ## [Unreleased]
 ### Changed
 - First couple of passes of tidying up approximately 40% of the manual fix cops
-  ([#1739](https://github.com/cucumber/cucumber-ruby/pull/1739) [#1740](https://github.com/cucumber/cucumber-ruby/pull/1740) [#1741](https://github.com/cucumber/cucumber-ruby/pull/1741) [luke-hill](https://github.com/luke-hill))
+  ([#1739](https://github.com/cucumber/cucumber-ruby/pull/1739) [#1740](https://github.com/cucumber/cucumber-ruby/pull/1740) [#1741](https://github.com/cucumber/cucumber-ruby/pull/1741) [#1742](https://github.com/cucumber/cucumber-ruby/pull/1742) [luke-hill](https://github.com/luke-hill))
 - Removed a bunch of example files / sample projects from ancient projects no longer viable
   [#1740](https://github.com/cucumber/cucumber-ruby/pull/1740) [luke-hill](https://github.com/luke-hill))
 

lib/cucumber/runtime/meta_message_builder.rb

@@ -5,14 +5,14 @@
 
 module Cucumber
   class Runtime
-    # Builder to instanciate a Cucumber::Messages::Meta message filled-in with
+    # Builder to instantiate a Cucumber::Messages::Meta message filled-in with
     # the runtime meta-data:
     # - protocol version: the version of the Cucumber::Messages protocol
     # - implementation: the name and version of the implementation (e.g. cucumber-ruby 8.0.0)
     # - runtime: the name and version of the runtime (e.g. ruby 3.0.1)
     # - os: the name and version of the operating system (e.g. linux 3.13.0-45-generic)
     # - cpu: the name of the CPU (e.g. x86_64)
-    # - ci: informtion about the CI environment if any, including:
+    # - ci: information about the CI environment if any, including:
     #   - name: the name of the CI environment (e.g. Jenkins)
     #   - url: the URL of the CI environment (e.g. https://ci.example.com)
     #   - build_number: the build number of the CI environment (e.g. 123)