dotnet: small code cleanup / no change of functionality and/or interface (#399)

* code cleanup / no change of functionality and/or interface

* code cleanup in tests

* cleanup warnings

Author: gasparnagy

dotnet/Cucumber.HtmlFormatter.sln.DotSettings

@@ -0,0 +1,3 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=15b5b1f1_002D457c_002D4ca6_002Db278_002D5615aedc07d3/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Static" AccessRightKinds="Private" Description="Static readonly fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="" Suffix="" Style="AaBb"&gt;&lt;ExtraRule Prefix="_" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;&lt;/Policy&gt;</s:String>
+	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=236f7aa5_002D7b06_002D43ca_002Dbf2a_002D9b31bfcff09a/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Private" Description="Constant fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="CONSTANT_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="" Suffix="" Style="AaBb"&gt;&lt;ExtraRule Prefix="" Suffix="" Style="AA_BB" /&gt;&lt;/Policy&gt;&lt;/Policy&gt;</s:String></wpf:ResourceDictionary>

dotnet/Cucumber.HtmlFormatter/JsonInHtmlWriter.cs

@@ -1,22 +1,15 @@
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Cucumber.HtmlFormatter;
+namespace Cucumber.HtmlFormatter;
 
 public class JsonInHtmlWriter : StreamWriter
 {
-    private readonly int BUFFER_SIZE = 1024;
-    private StreamWriter Writer;
-    private char[] escapeBuffer;
+    private const int BUFFER_SIZE = 1024;
+    private readonly StreamWriter _writer;
+    private readonly char[] _escapeBuffer;
 
     public JsonInHtmlWriter(StreamWriter writer) : base(writer.BaseStream)
     {
-        Writer = writer;
-        escapeBuffer = new char[BUFFER_SIZE]; // Initialize escapeBuffer
+        _writer = writer;
+        _escapeBuffer = new char[BUFFER_SIZE]; // Initialize escapeBuffer
     }
 
     public override void Write(string value)
@@ -39,17 +32,17 @@ public override void Write(char[] source, int offset, int length)
         if (offset + length > source.GetLength(0))
             throw new ArgumentException("Cannot read past the end of the input source char array.");
 
-        char[] destination = PrepareBuffer();
-        int flushAt = BUFFER_SIZE - 2;
-        int written = 0;
-        for (int i = offset; i < offset + length; i++)
+        var destination = PrepareBuffer();
+        var flushAt = BUFFER_SIZE - 2;
+        var written = 0;
+        for (var i = offset; i < offset + length; i++)
         {
-            char c = source[i];
+            var c = source[i];
 
             // Flush buffer if (nearly) full
             if (written >= flushAt)
             {
-                Writer.Write(destination, 0, written);
+                _writer.Write(destination, 0, written);
                 written = 0;
             }
 
@@ -63,7 +56,7 @@ public override void Write(char[] source, int offset, int length)
         // Flush any remaining
         if (written > 0)
         {
-            Writer.Write(destination, 0, written);
+            _writer.Write(destination, 0, written);
         }
     }
 
@@ -72,17 +65,17 @@ public override async Task WriteAsync(char[] source, int offset, int length)
         if (offset + length > source.GetLength(0))
             throw new ArgumentException("Cannot read past the end of the input source char array.");
 
-        char[] destination = PrepareBuffer();
-        int flushAt = BUFFER_SIZE - 2;
-        int written = 0;
-        for (int i = offset; i < offset + length; i++)
+        var destination = PrepareBuffer();
+        var flushAt = BUFFER_SIZE - 2;
+        var written = 0;
+        for (var i = offset; i < offset + length; i++)
         {
             char c = source[i];
 
             // Flush buffer if (nearly) full
             if (written >= flushAt)
             {
-                await Writer.WriteAsync(destination, 0, written);
+                await _writer.WriteAsync(destination, 0, written);
                 written = 0;
             }
 
@@ -96,28 +89,28 @@ public override async Task WriteAsync(char[] source, int offset, int length)
         // Flush any remaining
         if (written > 0)
         {
-            await Writer.WriteAsync(destination, 0, written);
+            await _writer.WriteAsync(destination, 0, written);
         }
     }
+
     private char[] PrepareBuffer()
     {
         // Reuse the same buffer, avoids repeated array allocation
-        escapeBuffer ??= new char[BUFFER_SIZE];
-        return escapeBuffer;
+        return _escapeBuffer;
     }
 
     public override void Flush()
     {
-        Writer.Flush();
+        _writer.Flush();
     }
 
     public override async Task FlushAsync()
     {
-        await Writer.FlushAsync();
+        await _writer.FlushAsync();
     }
 
     public override void Close()
     {
-        Writer.Close();
+        _writer.Close();
     }
 }